1666723 - Remember whether a server is speaking HTTP3

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Dragana Damjanovic [:dragana]]

This is a info that we need for HTTP3 performance telemetry.

We want to record in the nsHttpChannel whether Http3 was advertised in a AltSvc.
We parse AltSvc here:
https://searchfox.org/mozilla-central/rev/35d927df97900a57ecb562ad13909e392440b0fb/netwerk/protocol/http/nsHttpChannel.cpp#2531

Just before that line we should parse the string and look for one of this strings:
https://searchfox.org/mozilla-central/rev/35d927df97900a57ecb562ad13909e392440b0fb/netwerk/protocol/http/nsHttp.cpp#31

Comment 1

[Hubert Boma Manilla (:bomsy)]

I would pick this up.

Hi dragana,
Please i've got some clarifications and questions

1. I would need to add a new telemetry definition to the Histogram file, is that correct?
2. Is there any documentation explaining the conventions to follow for creating definitions?
3. For the telemetry , would a boolean recording whether Http3 was advertised in a AltSvc be enough or do i store the http3 version string?
4. Is there any quick way test that the telemetry added works?

Thanks alot.

Comment 2

[Dragana Damjanovic [:dragana]]

Hi, I should have been more specific. In this bug we will only add a variable to Http3Channel. We will not add any telemetry probes. We need this flag for the telemetry probes described in bug 1657169 and in couple other bugs that I need to open.

Comment 3

[Dragana Damjanovic [:dragana]]

he variable is just a bool.

Comment 4

[Hubert Boma Manilla (:bomsy)]

Ok that makes sense

Thanks

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1666723 - Track that http3 is advertised / supported r=dragana

Comment 6

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1666723 - Expose and add a test r=dragana

Depends on D93137

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a10a3a34f8f
Track that http3 is advertised / supported r=dragana,necko-reviewers,valentin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c84ca8e6e685
Expose  and add a test r=dragana,necko-reviewers

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6a10a3a34f8f

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c84ca8e6e685