Closed Bug 1666734 Opened 1 year ago Closed 11 months ago

Add "Print on both sides" checkbox option to new print UI (duplex printing)

Categories

(Toolkit :: Printing, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox84 --- verified
firefox85 --- verified

People

(Reporter: jwatt, Assigned: nordzilla)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Whiteboard: [print2020_v84][old-ui-])

Attachments

(1 file, 1 obsolete file)

Bug 1651115 added nsIPrinter.supportsDuplex that can be used to determine whether a printer supports duplex printing. (That may be made per-paper information in bug 1658394.) If nsIPrinter.supportsDuplex is true, then we should expose this is the UI. The frontend code would set nsIPrintSettings.duplex to one of kDuplexHorizontal or kDuplexVertical if duplex is supported, based on whether the user selects "Flip on long edge" or "Flip on short edge".

This is required for parity with the legacy UI and parity with Chrome.

Duplicate of this bug: 1669354
Summary: Add "Print on both sides" checkbox and "Flip on long edge"/"Flip on short edge" options to new print UI → Add "Print on both sides" checkbox and "Flip on long edge"/"Flip on short edge" options to new print UI (duplex printing)

Going to take a crack at this in an attempt to get somewhat familiar with the front-end code.

I'm expecting that new code here will be very similar to existing code.

Also, I've been working on the platform side of this functionality (Bug 1658394), so it seems like a good bug to start with.

Assignee: nobody → enordin
Status: NEW → ASSIGNED
Depends on: 1658394
Attachment #9181708 - Attachment description: Bug 1666734 - WIP → Bug 1666734 - Add two-sided printing checkbox to print UI
Attachment #9181708 - Attachment description: Bug 1666734 - Add two-sided printing checkbox to print UI → Bug 1666734 - Add two-sided printing checkbox to print UI r=sfoster,mstriemer,emalysz
Summary: Add "Print on both sides" checkbox and "Flip on long edge"/"Flip on short edge" options to new print UI (duplex printing) → Add "Print on both sides" checkbox option to new print UI (duplex printing)
Blocks: 1671702

(Moving to 84.)

Whiteboard: [print2020_v83][old-ui-] → [print2020_v84][old-ui-]
Attachment #9181708 - Attachment description: Bug 1666734 - Add two-sided printing checkbox to print UI r=sfoster,mstriemer,emalysz → Bug 1666734 - Add two-sided printing checkbox to print UI r=sfoster,alaskanemily
No longer blocks: 1671702

NI'ing Emilio as per our conversation on Matrix, to see if he might have any insights into this intermittent leak until shutdown that is happening on macOS, triggered by the new test cases that this patch adds.

I've been trying to get to the bottom of it for some time now, with little luck so far.

Example:

https://treeherder.mozilla.org/jobs?repo=try&revision=162bf2d6fb7f8133b3ec211b26999155556d7fa9&selectedTaskRun=dYwKTfu8TdeIuaveZgdzFw.0

Flags: needinfo?(emilio)

I tried to repro this on Linux and no dice. Will try on Mac and see if I can poke a bit more.

I tried to repro on mac with a debug artifact build and couldn't either... Did about 6 runs of ./mach mochitest browser_print_duplex.js --verify...

However per our discussion, TV doesn't necessarily block landing, so we might want to try to land it if it doesn't fail when ran in regular mochitests... If we do that it'd be nice to keep a bug on file to track why is this failing on TV.

I'd also be interested in knowing whether other printing tests fail similarly on verify...

Flags: needinfo?(emilio)
Pushed by enordin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/905f54a1dfed
Add two-sided printing checkbox to print UI r=sfoster,fluent-reviewers,flod,AlaskanEmily

I accidentally missed a line when resolving a merge conflict and it sneaked its way into that test. So sorry about that.

Flags: needinfo?(enordin)
Pushed by enordin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0ccf52ee836
Add two-sided printing checkbox to print UI r=sfoster,fluent-reviewers,flod,AlaskanEmily
Attachment #9186245 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Flags: qe-verify+

I retested everything using latest Nightly 85.0a1 and Firefox 84.0b3 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 11.1. The "Print on both sides" checkbox option is displayed underneath the "Two-sided printing" section.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1689412
Blocks: 1702501
You need to log in before you can comment on or make changes to this bug.