1666734 - Add "Print on both sides" checkbox option to new print UI (duplex printing)

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P2)

Description

[Jonathan Watt [:jwatt]]

Bug 1651115 added nsIPrinter.supportsDuplex that can be used to determine whether a printer supports duplex printing. (That may be made per-paper information in bug 1658394.) If nsIPrinter.supportsDuplex is true, then we should expose this is the UI. The frontend code would set nsIPrintSettings.duplex to one of kDuplexHorizontal or kDuplexVertical if duplex is supported, based on whether the user selects "Flip on long edge" or "Flip on short edge".

This is required for parity with the legacy UI and parity with Chrome.

Comment 2

[Erik Nordin [:nordzilla]]

Going to take a crack at this in an attempt to get somewhat familiar with the front-end code.

I'm expecting that new code here will be very similar to existing code.

Also, I've been working on the platform side of this functionality (Bug 1658394), so it seems like a good bug to start with.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1666734 - Add two-sided printing checkbox to print UI r=sfoster,alaskanemily

Comment 4

[Blake Winton (:bwinton) (:☕️)]

(Moving to 84.)

Comment 5

[Erik Nordin [:nordzilla]]

NI'ing Emilio as per our conversation on Matrix, to see if he might have any insights into this intermittent leak until shutdown that is happening on macOS, triggered by the new test cases that this patch adds.

I've been trying to get to the bottom of it for some time now, with little luck so far.

Example:

https://treeherder.mozilla.org/jobs?repo=try&revision=162bf2d6fb7f8133b3ec211b26999155556d7fa9&selectedTaskRun=dYwKTfu8TdeIuaveZgdzFw.0

Comment 6

[Sam Foster [:sfoster] (he/him)]

I got this try run with all but the last of the duplex browser tests skipped, so the log is a bit easier to scan through:

• https://treeherder.mozilla.org/jobs?repo=try&revision=3cc40e0b5d7a7b8dcd15e321c9f60ae324199d01&selectedTaskRun=G4kJ8lsYTqGKDUk3Z0qXaA.0
• https://firefoxci.taskcluster-artifacts.net/G4kJ8lsYTqGKDUk3Z0qXaA/0/public/logs/live_backing.log

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I tried to repro this on Linux and no dice. Will try on Mac and see if I can poke a bit more.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I tried to repro on mac with a debug artifact build and couldn't either... Did about 6 runs of ./mach mochitest browser_print_duplex.js --verify...

However per our discussion, TV doesn't necessarily block landing, so we might want to try to land it if it doesn't fail when ran in regular mochitests... If we do that it'd be nice to keep a bug on file to track why is this failing on TV.

I'd also be interested in knowing whether other printing tests fail similarly on verify...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/905f54a1dfed
Add two-sided printing checkbox to print UI r=sfoster,fluent-reviewers,flod,AlaskanEmily

Comment 10

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=bgulm5SDTHqFgjc_HmBOZQ.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx64%2Copt%2Cmochitests%2Cwithout%2Ce10s%2Ctest-windows10-64%2Fopt-mochitest-chrome-1proc%2Cc2&revision=905f54a1dfed94433ed640423f31ab0c50f5ae44

Log: https://treeherder.mozilla.org/logviewer?job_id=320922918&repo=autoland&lineNumber=1751

Backout: https://hg.mozilla.org/integration/autoland/rev/d6963d98cd379c66cc3b348a29e18a8e6d1bbb7d

Comment 11

[Erik Nordin [:nordzilla]]

I accidentally missed a line when resolving a merge conflict and it sneaked its way into that test. So sorry about that.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0ccf52ee836
Add two-sided printing checkbox to print UI r=sfoster,fluent-reviewers,flod,AlaskanEmily

Comment 13

[Chris H-C :chutten]

Attachment: Backed out changeset 905f54a1dfed (Bug 1666734) for perma failures on test_get_printer_paper_sizes.html. CLOSED TREE

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e0ccf52ee836

Comment 15

[Oana Botisan, Desktop QA]

I retested everything using latest Nightly 85.0a1 and Firefox 84.0b3 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 11.1. The "Print on both sides" checkbox option is displayed underneath the "Two-sided printing" section.