1666746 - Refactoring in PLDHashTable

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Paul Bone [:pbone]]

I have some patches that refactor some things in PLDHashTable

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1666746 - pt 1. Add an IsAllocated method r=njn

Adding this method makes it clearer what code is doing when it checks that
the storage has been allocated.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1666746 - pt 2. Reuse SlotForIndex to avoid duplicate code r=njn

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1666746 - pt 3. Improve some messages from TestPLDHash r=njn

Add labels to some console messages in this test so that the caller can be
identified easilly.

Depends on D89566

Comment 4

[Paul Bone [:pbone]]

Hi Nicholas,

I wrote the first two patches earlier and Nathan accepted them, but phabricator won't let me update them with his name. I hope it's okay I changed the titles to have r=njn.

Thanks.

Comment 5

[Nicholas Nethercote [inactive]]

That's fine.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22edc401b98b
pt 1. Add an IsAllocated method r=froydnj
https://hg.mozilla.org/integration/autoland/rev/4577271681e9
pt 2. Reuse SlotForIndex to avoid duplicate code r=froydnj
https://hg.mozilla.org/integration/autoland/rev/33d86022eaf4
pt 3. Improve some messages from TestPLDHash r=njn

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/22edc401b98b
https://hg.mozilla.org/mozilla-central/rev/4577271681e9
https://hg.mozilla.org/mozilla-central/rev/33d86022eaf4