1666782 - the image looks distorted in latest nighty

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[ignus]

Attachment: Image.png

Add the image as attachment

Mozregression log:

2020-09-23T20:07:27.084000: INFO : Narrowed integration regression window from [643aa6ba, 25a50264] (3 builds) to [98c40963, 25a50264] (2 builds) (~1 steps left)
2020-09-23T20:07:27.097000: DEBUG : Starting merge handling...
2020-09-23T20:07:27.097000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=25a50264ae3204f2df9add308fc712df45947637&full=1
2020-09-23T20:07:27.097000: DEBUG : redo: attempt 1/3
2020-09-23T20:07:27.097000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=25a50264ae3204f2df9add308fc712df45947637&full=1',), kwargs: {}, attempt #1
2020-09-23T20:07:27.100000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2020-09-23T20:07:28.512000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=25a50264ae3204f2df9add308fc712df45947637&full=1 HTTP/1.1" 200 None
2020-09-23T20:07:28.558000: DEBUG : Found commit message:
Bug 1666057. Convert qcms to rust. r=aosmond

The conversion was done with c2rust and then manually cleaned up some.
There's still lots of unsafe code remaining but I'd rather do the rest
of the cleanup in-tree so that it's easier to catch and revert
regressions.

I've dropped support for SSE1 (Firefox requires SSE2) and Altivec
(not wanting to deal with fixing Rust's Altivec support).

transform_neon.rs manually implements a bunch of intrinsics, this
can be fixed when we can depend on Rust 1.48.

The fuzz target is changed to a cargo-fuzz target.

Some of the gtests are moved to Rust.

Differential Revision: https://phabricator.services.mozilla.com/D90782

2020-09-23T20:07:28.558000: DEBUG : Did not find a branch, checking all integration branches
2020-09-23T20:07:28.562000: INFO : The bisection is done.
2020-09-23T20:07:28.565000: INFO : Stopped

Comment 1

[ignus]

Attachment: Troubleshooting_Information.txt

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This is probably because https://searchfox.org/mozilla-central/source/gfx/qcms/src/transform.rs#246 is wrong

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1666782. Fix GrayAlpha color conversion.

GrayAlpha::has_alpha was accidentally set to false.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18f568385c3b
Fix GrayAlpha color conversion. r=aosmond

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/18f568385c3b