1666792 - Not able to select first option in the location dropdown of StackOverflow's job application page in Desktop Site mode

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Arturo Mejia [:amejia]]

Steps to reproduce in the Fenix issue. Reproducible in GV: 82.0a1-20200920213416 and in GVE app.

Comment 1

[Botond Ballo [:botond]]

I got a regression window with GVE. It points to:

Bug 1618532 - Re-enable mouse event retargeting on Android

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Looks like there's nothing on the dropdown list elements that makes them mouse targets. The first item in the list is close enough to the input box that any attempts to tap on it just get retargeted to the input box.

Inspecting the dropdown elements in Chrome (after removing the blur listener on the input element, which apparently I can't do in Firefox) shows almost nothing interesting about the elements except a mousemove listener. So maybe we can use that. All the actual important click listeners are on the html or body elements.

Another option is that the pac-container parent element has a z-index:9999 which is kind of a signal that it's important and mouse events should not get retargeted to outside it. So maybe we can restrict the retarget to be inside frames with sufficiently high z-index.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I think the z-index idea is probably the one worth going with here, but I'm not sure how z-index is used in practice. It seems like it would be used for things like web modal dialogs and popup implementations, where it makes sense that we probably don't want to retarget events that land on the z-island to things outside of it. I wrote a patch that does this and it seems to work in this case. Not sure if it is too conservative and will disable retargeting in a lot of scenarios where it's useful, but I guess we can see.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f09f8e72d7b536901778f7c499a5afe323cbb266

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1666792 - Don't allow events to get retargeted outside the nearest z-index container. r?emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bf9fe1b7d16
Don't allow events to get retargeted outside the nearest z-index container. r=emilio

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2bf9fe1b7d16

Comment 8

[Laurentiu Apahidean]

Verified as fixed on Firefox Preview Nightly 201025 (Build #2015771787) using a Pixel 3 XL (Android 9) and Samsung Galaxy S9 (Android 8.0.0).