Closed Bug 1666817 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25712 - Use allow attribute for delegation in WebUSB WPT

Categories

(Core :: DOM: Device Interfaces, task, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25712 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25712
Details from upstream follow.

b'Ian Clelland <iclelland@chromium.org>' wrote:

Use allow attribute for delegation in WebUSB WPT

With an upcoming change to Feature/Permissions Policy, the header
alone will no longer be sufficient to delegate permissions to use
powerful features in subframes. The iframe allow attribute must
be used in conjunction with it. The header can still be used to
block delegation.

This change updates the WebUSB WPTs to use the allow attribute for
delegation.

Bug: 1095641
Change-Id: I278d5f3b9a105b5ed0ac556223908dc83524ef7d
Reviewed-on: https://chromium-review.googlesource.com/2424634
WPT-Export-Revision: e25afacf2bf3078cfdd0db22599937624381aa5a

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

FAIL : 4
TIMEOUT: 3

Chrome

OK : 1
PASS : 6

Safari

FAIL : 4
TIMEOUT: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webusb/usb-allowed-by-feature-policy.https.sub.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
Feature-Policy header {"usb" : [""]} allows the top-level document.: FAIL (Chrome: PASS, Safari: FAIL)
Feature-Policy header {"usb" : [""]} allows same-origin iframes.: FAIL (Chrome: PASS, Safari: FAIL)
Feature-Policy header {"usb" : [""]} allows workers in same-origin iframes.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
Feature-Policy header {"usb" : [""]} allows cross-origin iframes.: FAIL (Chrome: PASS, Safari: FAIL)
Feature-Policy header {"usb" : ["*"]} allows workers in cross-origin iframes.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
Inherited header feature policy allows dedicated workers.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webusb/usb-allowed-by-feature-policy.https.sub.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adf977c0b0ec
[wpt PR 25712] - Use allow attribute for delegation in WebUSB WPT, a=testonly

https://hg.mozilla.org/mozilla-central/rev/adf977c0b0ec

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.