Closed Bug 1666820 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25715 - Use allow attribute for delegation in wake-lock WPT

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox83 fixed)

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25715 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25715
Details from upstream follow.

b'Ian Clelland <iclelland@chromium.org>' wrote:

Use allow attribute for delegation in wake-lock WPT

With an upcoming change to Feature/Permissions Policy, the header
alone will no longer be sufficient to delegate permissions to use
powerful features in subframes. The iframe allow attribute must
be used in conjunction with it. The header can still be used to
block delegation.

This change updates the screen wake lock WPTs to use the allow
attribute for delegation.

Bug: 1095641
Change-Id: Iecc6d0ce8840013c9dc570e76b1c02510eb89fef
Reviewed-on: https://chromium-review.googlesource.com/2424633
WPT-Export-Revision: c994247a2cd7e8e20cfb90af2ae539ce6e125450

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
PASS: 1
FAIL: 2

Safari

OK : 1
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/screen-wake-lock/wakelock-enabled-by-feature-policy.https.sub.html
Feature-Policy header {"screen-wake-lock" : [""]} allows the top-level document.: FAIL (Chrome: PASS, Safari: FAIL)
Feature-Policy header {"screen-wake-lock" : [""]} allows same-origin iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Feature-Policy header {"screen-wake-lock" : ["*"]} allows cross-origin iframes.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/307ca8c1330b
[wpt PR 25715] - Use allow attribute for delegation in wake-lock WPT, a=testonly

https://hg.mozilla.org/mozilla-central/rev/307ca8c1330b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.