Have a way to limit certain regions from seeing newtab stories
Categories
(Firefox :: New Tab Page, enhancement)
Tracking
()
People
(Reporter: thecount, Assigned: thecount)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
Right now we have a list of regions that see stories in newtab.
We're looking at going global with English stories in English browsers.
However, certain regions might have restrictions, so we want another list of regions to restrict. Probably a pref.
Logic is probably something like this:
if (region in block list) {
// do not show stories
return;
} else if (browser is English) {
// show stories
return;
} else if (region in allow list) {
// show stories
return;
} else {
// do not show stories
return;
}
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
To test:
- Create a new profile.
- Have it be an English locale.
- Set browser.search.region to "FR"
- Set browser.newtabpage.activity-stream.discoverystream.locale-list-config to "en-US,en-CA,en-GB"
- Restart
- Open a newtab
Expected: You should see stories.
- Set browser.newtabpage.activity-stream.discoverystream.region-stories-block to "FR"
- Restart
- Open a newtab
Expected: should no longer see stories.
Comment 4•4 years ago
|
||
bugherder |
Assignee | ||
Comment 5•4 years ago
|
||
[Tracking Requested - why for this release]: Finishing up an experiment where we show Pocket stories for English browsers globally. If this looks good, we'll want to turn it on, and for that, we need this bug fixed in 82.
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9178005 [details]
Bug 1666892 - Be able to turn off newtab stories based on region.
Beta/Release Uplift Approval Request
- User impact if declined: Impact to our global reach.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: To test:
- Create a new profile.
- Have it be an English locale.
- Set browser.search.region to "FR"
- Set browser.newtabpage.activity-stream.discoverystream.locale-list-config to "en-US,en-CA,en-GB"
- Restart
- Open a newtab
Expected: You should see stories.
- Set browser.newtabpage.activity-stream.discoverystream.region-stories-block to "FR"
- Restart
- Open a newtab
Expected: should no longer see stories.
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): The code's not a lot, and it has tests.
- String changes made/needed: none
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Verified - Fixed in latest Nightly 83.0a1 (2020-09-30) (build id: 20200930092918) using Windows 10 and Ubuntu 18.04. Following the steps 1-6 the stories are displayed in the new tab. After steps 7-9 the stories are no longer displayed.
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Comment on attachment 9178005 [details]
Bug 1666892 - Be able to turn off newtab stories based on region.
approved for 82.0b6
Comment 9•4 years ago
|
||
bugherder uplift |
Comment 10•4 years ago
|
||
Verified - Fixed in latest Beta 82.0b6 (build id: 20201001171107) with the mention that after first 6 steps, browser.newtabpage.activity-stream.discoverystream.region-stories-block is already set to "FR" and the stories are not displayed.
Description
•