1666993 - Report during review phase build errors for files that have been fixed to be compatible to the non-unified system

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Andi [:andi]]

Since we've started fixing modules for mozilla-central in order to have the compile outside of the unified environment we should have a mechanism in place that reports errors when patches break them.

Comment 1

[Andi [:andi]]

Attachment: Bug 1666993 - new bakend for static-analysis that prevents regressing issues with files that can be built outside of the unified environment.

1. We build a list with directories, from non-unified-compat that have been fixed and
   permit compiling of C++ files outside of the unified environment. With this list
   we eliminate the unified sources and instead use the original source for command
   attribute from compile_commands.json.
   In this way if a regression appears clang-tidy will report it since it no longer uses
   the unified environment for files that are compatible to be compiled standalone.

2. Remove the coverity functionality that was reading and using non-unified build files
   since in practive it prooved to be sub-optimal.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3423677b0444
new bakend for static-analysis that prevents regressing issues with files that can be built outside of the unified environment. r=botond

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3423677b0444