1666995 - Missing string errors in preferences tab search

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Geoff Lankow (:darktrojan)]

[fluent] Missing translations in en-US: certmgr-servers, delete-ssl-cert-title, delete-ssl-cert-confirm, delete-ssl-cert-impact.
Missing search l10n id "certmgr-servers"
Missing search l10n id "delete-ssl-cert-title"
Missing search l10n id "delete-ssl-cert-confirm"
Missing search l10n id "delete-ssl-cert-impact"
[fluent] Missing translations in en-US: fips-nonempty-password-required.
Missing search l10n id "fips-nonempty-password-required"

I'm guessing these are strings that once existed but no longer do.

Comment 1

[Thomas D. (:thomas8)]

(In reply to Geoff Lankow (:darktrojan) from comment #0)

I'm guessing these are strings that once existed but no longer do.

Strange. Most of these translations exist, but they are only used in search-l10n-ids attribute for searching preferences, i.e. they do not have any actual use in the application where they would actually ever show. So if we are not using them in the application, I guess they must be removed from the search attribute also. We can't remove them from the ftls because these are third-party. Does that make sense?

[fluent] Missing translations in en-US: certmgr-servers, delete-ssl-cert-title, delete-ssl-cert-confirm, delete-ssl-cert-impact.
Missing search l10n id "certmgr-servers"

https://searchfox.org/comm-central/search?path=&q=certmgr-servers
Exists in ftl, but used only in search-l10n-ids attribute, not used for real in any other file.

Missing search l10n id "delete-ssl-cert-title"

https://searchfox.org/comm-central/search?q=delete-ssl-cert-

delete-ssl-cert-title: listed in certManager.ftl, but empty (no translation).
Wrongly used as delete-ssl-cert-title.title (sic) in search-l10n-ids attribute in privacy.inc.xhtml, i.e. not used anywhere for real.

Missing search l10n id "delete-ssl-cert-confirm"
Missing search l10n id "delete-ssl-cert-impact"

https://searchfox.org/comm-central/search?q=delete-ssl-cert-
Exist in certManager.ftl, but only used in search-l10n-ids attribute in privacy.inc.xhtml, i.e. not used anywhere for real.

[fluent] Missing translations in en-US: fips-nonempty-password-required.
Missing search l10n id "fips-nonempty-password-required"

https://searchfox.org/comm-central/search?path=&q=fips-nonempty-password-required
Exists in deviceManager.ftl, but only used in search-l10n-ids attribute in privacy.inc.xhtml, i.e. not used anywhere for real.

Comment 2

[Khushil Mistry [:khushil324]]

(In reply to Thomas D. (:thomas8) from comment #1)

Strange. Most of these translations exist, but they are only used in search-l10n-ids attribute for searching preferences, i.e. they do not have any actual use in the application where they would actually ever show. So if we are not using them in the application, I guess they must be removed from the search attribute also. We can't remove them from the ftls because these are third-party. Does that make sense?

These strings are used in searching in the dialog. We look into search-l10n-ids attribute of the button and look into every correspondent string and create a tooltip if the search word is present. Device Manager and Certificate Manager dialogs are coming from mozilla-central. So related strings are also coming from deviceManager.ftl and certManager.ftl which are in mozilla-central repo.

Comment 3

[Thomas D. (:thomas8)]

(In reply to Khushil Mistry [:khushil324] from comment #2)

(In reply to Thomas D. (:thomas8) from comment #1)
These strings are used in searching in the dialog. We look into search-l10n-ids attribute of the button and look into every correspondent string and create a tooltip if the search word is present. Device Manager and Certificate Manager dialogs are coming from mozilla-central. So related strings are also coming from deviceManager.ftl and certManager.ftl which are in mozilla-central repo.

I understand that, but what's the point of finding strings which are not actually used anywhere in our entire application?
So the button tooltip will promise that I can find my searchword behind the button, but it won't be there...

Comment 4

[Khushil Mistry [:khushil324]]

Ohh Okay, got it. Submitting a patch in a while.

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1666995_missing-string-errors-preferences-tab-search-0.patch

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9177850 [details] [diff] [review]
Bug-1666995_missing-string-errors-preferences-tab-search-0.patch

Review of attachment 9177850 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/preferences/privacy.inc.xhtml
@@ -482,4 @@
>                        delete-user-cert-title.title,
>                        delete-user-cert-confirm,
>                        delete-user-cert-impact,
> -                      delete-ssl-cert-title.title,

This one, well the corresponding one exists. https://searchfox.org/comm-central/source/mozilla/security/manager/locales/en-US/security/certificates/certManager.ftl#166

Please check the others as well, I suspsect they might have been changed

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: Bug-1666995_missing-string-errors-preferences-tab-search-1.patch

Updated the patch according to the new strings.

Comment 8

[Magnus Melin [:mkmelin]]

Please set flags for which version(s) are affected.

Comment 9

[Khushil Mistry [:khushil324]]

This issue is on the Trunk as well as Beta 82.0b1. 81.0b4 doesn't show these errors.

Comment 10

[Khushil Mistry [:khushil324]]

Comment on attachment 9177868 [details] [diff] [review]
Bug-1666995_missing-string-errors-preferences-tab-search-1.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Error in the console and may cause search problem in the preference window.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/04fd74f4ef41
Fix missing string errors in preferences tab search. r=mkmelin

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9177868 [details] [diff] [review]
Bug-1666995_missing-string-errors-preferences-tab-search-1.patch

[Triage Comment]
Approved for beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 82.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/edcec0d16bc9