1667007 - error: static assertion failed: MPSCQueue internal allocations too big.

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Mike Hommey [:glandium]]

This error appears when building on Linux mipsel.

/<<PKGBUILDDIR>>/dom/media/AsyncLogger.h:93:58: error: static assertion failed: MPSCQueue internal allocations too big.
   93 |   static_assert(sizeof(MPSCQueue<TracePayload>::Message) <= PAYLOAD_TOTAL_SIZE,
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~

The problem is that the PADDING calculation doesn't account for special cases of alignment on some platforms.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1667007 - Fix AsyncLogger::TracePayload's mName size calculation.

such that it accounts for alignment of TracePayload itself in MPSCQueue
correctly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7dec549998f
Fix AsyncLogger::TracePayload's mName size calculation. r=padenot

Comment 3

[tt_1]

does this only affect v83 branch?

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9177563 [details]
Bug 1667007 - Fix AsyncLogger::TracePayload's mName size calculation.

Beta/Release Uplift Approval Request

• User impact if declined: Build failure on some tier-3 platforms
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The resulting code is stricter than the current code in what it expects the struct size to be (== rather than <=), so if the struct size doesn't actually end up with the expected size, the build will fail, which it doesn't as far as testing on tier-1 and some tier-3 platforms showed.
• String changes made/needed:

Comment 5

[tt_1]

I'm asking, since I'm loosly associated with packaging firefox for gentoo, but don't have own mips/mipsel hardware to test this with. So maybe I can help the few brave souls out there with picking up the patch for 78-esr

Comment 6

[Mike Hommey [:glandium]]

It doesn't affect esr78.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a7dec549998f

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9177563 [details]
Bug 1667007 - Fix AsyncLogger::TracePayload's mName size calculation.

approved for 82.0b4

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d651e1e0fe48