Closed Bug 166711 Opened 22 years ago Closed 22 years ago

SSLSocket.setCipherPreference does the wrong thing

Categories

(JSS Graveyard :: Library, defect)

Product:
JSS Graveyard
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jamie-bugzilla, Assigned: jamie-bugzilla)

Details

The documentation for setCipherPreference says that it "Enables/disables the given cipher on this socket." This makes sense, given the name of the method. Unfortunately, this method is static, and invokes SSL_CipherPrefSetDefault, which sets the _default_ cipher preference. I'm going to change this method to do what the documentation and name imply, and create a new method to set the default cipher pref. I'll also add two new methods for getting the settings.
Fixed on trunk. /cvsroot/mozilla/security/jss/org/mozilla/jss/ssl/SSLClient.java,v <-- SSLClient.java new revision: 1.5; previous revision: 1.4 /cvsroot/mozilla/security/jss/org/mozilla/jss/ssl/SSLServer.java,v <-- SSLServer.java new revision: 1.4; previous revision: 1.3 /cvsroot/mozilla/security/jss/org/mozilla/jss/ssl/SSLServerSocket.java,v <-- SSLServerSocket.java new revision: 1.14; previous revision: 1.13 /cvsroot/mozilla/security/jss/org/mozilla/jss/ssl/SSLSocket.c,v <-- SSLSocket.c new revision: 1.17; previous revision: 1.16 /cvsroot/mozilla/security/jss/org/mozilla/jss/ssl/SSLSocket.java,v <-- SSLSocket.java new revision: 1.16; previous revision: 1.15 /cvsroot/mozilla/security/jss/org/mozilla/jss/ssl/SocketBase.java,v <-- SocketBase.java new revision: 1.9; previous revision: 1.8
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2.1
Also: /cvsroot/mozilla/security/jss/lib/jss.def,v <-- jss.def new revision: 1.20; previous revision: 1.19
Rename JSS 3.2.1 to JSS 3.3.
Target Milestone: 3.2.1 → 3.3
You need to log in before you can comment on or make changes to this bug.