Perma browser/components/urlbar/tests/browser/browser_remove_match.js | Test timed out - and many more failure when Gecko 83 merges to Beta on 2020-10-19
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox81 | --- | unaffected |
firefox82 | --- | unaffected |
firefox83 | + | verified |
People
(Reporter: aryx, Assigned: mak)
Details
Attachments
(2 files)
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=316587529&repo=try
[task 2020-09-24T13:47:45.671Z] 13:47:45 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_remove_match.js | Found one-off button for search mode - {"engine":{"_name":"test","_loadPath":"[other]addEngineWithDetails:test@test.engine","description":"undefined","__searchForm":"http://example.com","_iconURL":"","_metaData":{"order":1,"loadPathHash":"2DNQef0rF/g9uGKBvrFDyd8AUrZ2OwDYrbZUYfTZbos="},"_urls":[{"params":[{"name":"q","value":"{searchTerms}"}],"rels":[],"resultDomain":"example.com","template":"http://example.com/"}],"_isAppProvided":false,"_orderHint":"undefined","_telemetryId":null,"_updateInterval":null,"_updateURL":null,"_iconUpdateURL":null,"_extensionID":"test@test.engine","_locale":"default","_definedAliases":[],"_hasPreferredIcon":null,"queryCharset":"windows-1252"},"_inheritedElements":{".button-icon":{}},"initializedAttributeInheritance":true} == true -
[task 2020-09-24T13:47:45.671Z] 13:47:45 INFO - Awaiting for the urlbar panel to open
[task 2020-09-24T13:47:45.671Z] 13:47:45 INFO - Buffered messages finished
[task 2020-09-24T13:47:45.671Z] 13:47:45 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_remove_match.js | Test timed out -
Reporter | ||
Comment 1•4 years ago
|
||
[Tracking Requested - why for this release]:
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Reporter | ||
Comment 3•4 years ago
|
||
One off the failure lines persists with the patch applied: https://treeherder.mozilla.org/logviewer.html#?job_id=316931076&repo=try
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_searchFunction.js | Should show or not the one-off search buttons - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_searchFunction.js :: assertOneOffButtonsVisible :: line 253
Assignee | ||
Comment 4•4 years ago
|
||
Ah, in comment 0 I only saw browser_remove_match.js and didn't look into browser_searchFunction.js... let me re-check.
Reporter | ||
Comment 5•4 years ago
|
||
There were many test failures but they are going to be fixed by your patch. Not sure if it is an issue with the test or the profile is still dirty from an earlier one.
Assignee | ||
Comment 6•4 years ago
|
||
If I run the test alone it doesn't fail, so it is apparently a combination of tests causing it.
Assignee | ||
Comment 7•4 years ago
|
||
It's actually due to a combination of things, but not my patch that caused the browser_remove_match.js failure.
- Bug 1665076 made search enter search mode if update 2 is true, but doesn't require oneOffsRefresh.
- browser_revert.js doesn't clear history after adding to it
- when browser_searchFunction.js reaches historyRestriction(), whether one-off buttons are visible or not depends on the presence of history and the value of oneOffsRefresh.
The update2 pref should probably have included oneOffsRefresh from the beginning, the current prefs situation is not optimal. Luckily it's a temporary situation. For now I'll fix the test to clean history and set oneOffsRefresh.
Assignee | ||
Comment 8•4 years ago
|
||
Updated•4 years ago
|
Reporter | ||
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d89a3a9389aa
https://hg.mozilla.org/mozilla-central/rev/3de15a4c8e27
Reporter | ||
Comment 11•4 years ago
|
||
Verified fixed with today's central-as-beta simulation.
Description
•