Closed Bug 1667155 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25777 - [AspectRatio] Fix bug in flex-aspect-ratio-024 test

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25777 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25777
Details from upstream follow.

b'Christian Biesinger <cbiesinger@chromium.org>' wrote:

[AspectRatio] Fix bug in flex-aspect-ratio-024 test

The problem with the test was that due to the way we calculate
the intrinsic sizes of an inline flexbox, we end up sizing the
flexbox to 20px wide and then "stretching" the flex item to that
width.

Instead, use a wrapping flex box where flex line sizing does not
have that issue.

R=ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 1117279
Change-Id: I719814fc5e4c570a100e131f4d903c09d4c05575
Reviewed-on: https://chromium-review.googlesource.com/2429543
WPT-Export-Revision: aa2ed67c4ff560996466b4976d4b16475b5d620a

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/flex-aspect-ratio-024.tentative.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92e92a20cb3b
[wpt PR 25777] - [AspectRatio] Fix bug in flex-aspect-ratio-024 test, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dbb7e787602f
[wpt PR 25777] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/92e92a20cb3b
https://hg.mozilla.org/mozilla-central/rev/dbb7e787602f

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.