166716 - PR_CreateFileMap should not assert

Status: VERIFIED FIXED

(NSPR :: NSPR, defect)

Description

[Julien Pierre]

Even though this function is not implemented, NSS 3.6 is calling it and checks
for PR_NOT_IMPLEMENTED_ERROR . Therefore, the assertion in this function needs
to be removed from the OS/2 NSPR code.

Comment 1

[Julien Pierre]

Attachment: patch to remove assertion from PR_CreateFileMap on OS/2

This is necessary for NSS 3.6 landing to Mozilla

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch

This patch removes the assertions from the unimplemented
memory-mapped file functions on OS/2 and Mac and adds
PR_SetError(PR_NOT_IMPLEMENTED_ERROR, 0) calls to those
functions on BeOS.  (The BeOS functions don't have the
assertions.)

Comment 3

[Wan-Teh Chang]

Patch checked into the tip, NSPR_4_2_BRANCH, and
NSPRPUB_PRE_4_2_CLIENT_BRANCH of NSPR.

Comment 4

[Mike Kaply [:mkaply]]

verify, this code was checked in.