Closed Bug 1667171 Opened 4 years ago Closed 4 years ago

Picture-in-Picture button doesn't switch mode and then hidden on twitch.tv

Categories

(Toolkit :: Video/Audio Controls, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1655802

People

(Reporter: raphael, Unassigned)

References

(Blocks 1 open bug)

Details

Hi folks!

I tested Picture-in-Picture for the Omnibus Foxfooding program and observed unexpected behavior with the Picture-in-Picture controls for live streams on Twitch with Twitch extensions enabled.

  • Platform: macOS Catalina Version 10.15.6
  • Version: Firefox Browser 81.0 (64-bit)
  • Locale: "en-US"
  • Profile: New
  • Shirley Omnibus experiment: Active (Treatment)

Steps-to-Reproduce:

  1. Navigate to https://www.youtube.com and play a video
  2. Switch to Picture-in-Picture mode
  3. Switch back to normal mode and pause video
  4. Open a New Tab and navigate to https://www.twitch.tv
  5. Browse the livestreams and play one with Twitch extensions enabled
  6. Mouse-over the video to show the Picture-in-Picture controls
  7. Pressing the button does not switch the video to Picture-in-Picture mode
  8. Move the cursor outside of the video and back over the video
  9. The Picture-in-Picture controls do not show
  10. Hovering over the livestream controls (Settings, Theatre Mode, Fullscreen) does cause the Picture-in-Picture controls to show again
  11. Double-click the video to switch to Fullscreen mode
  12. Press ESC to exit Fullscreen mode
  13. Mouse-over the video to show the Picture-in-Picture controls
  14. The Picture-in-Picture controls do not show

You can find a screen recording demonstrating this behavior in my Google Drive

Hello Raphael,

Thank you for filing this bug and for dedicating your time to test this experiment. Your observations are spot on!

I’ve taken a look into all the provided steps and here are my findings:

  • For the behavior mentioned in step 7, the expected behavior is to have the “Picture-in-Picture” opened when the toggle is clicked which, as you observed, it does not. However, this is already tracked in bug 1655802.
  • For the behavior mentioned in step 9 and step 14, the expected behavior is to have the “Picture-in-Picture” toggle visible when the mouse is over the video. This is also a bug that was filed a while ago, and you can find it here: bug 1543805.

That being said, there are a few workarounds for these issues:

  1. The easiest one is to disable the twitch extension and then the “Picture-in-Picture” toggle should be both clickable and visible.
  2. The second method is to navigate to the “about:config” page and change the value of the “media.videocontrols.picture-in-picture.video-toggle.position” pref from “right” to “left”.
  3. Using the “Picture-in-Picture” keyboard shortcut “Ctrl+Shift+]” for Windows and Linux or “Cmd+Shift+Opt+]”. However, for this workaround, make sure that the Twitch page is focused and not the Twitch extension.

Considering this, would you be OK with closing this bug as a duplicate of either of the 2 bugs mentioned above?

Flags: needinfo?(rpierzina)

Hi Robert,

Thank you for reviewing this bug. I'm happy for you to close this bug as a duplicate if you think the other bugs adequately describe the issues and the behavior is not related to the omnibus experiment.

As for the workarounds you provided:

  1. I don't think viewers can disable Twitch extensions that a streamer enabled (see Twitch help article)
  2. Updating the position pref does move the video-toggle, but it does not seem resolve the problem that the video-toggle is not clickable.
  3. The keyboard shortcut "Cmd+Shift+Option+]" doesn't seem to work for me in Firefox 81 on macOS
Flags: needinfo?(rpierzina)

The keyboard shortcut issue on macOS was resolved in 82 (bug 1599376).

Hi Raphael,

Thank you for investigating these issues even further. I will reply in-line to your observations.

  1. I don't think viewers can disable Twitch extensions that a streamer enabled (see Twitch help article)

You are completely correct. I've phrased that incorrectly. A user cannot disable the extension, however, they can make it invisible with the "Visible" toggle provided in their UI. That being said, this is a once per session workaround so if you refresh the page, the extension is again visible. This issue is tracked in bug 1655802.

  1. Updating the position pref does move the video-toggle, but it does not seem resolve the problem that the video-toggle is not clickable.

I think this one depends on the amount of screen surface the extension’s transparent iframe covers. This issue will probably be fixed once bug 1543805 is fixed.

  1. The keyboard shortcut "Cmd+Shift+Option+]" doesn't seem to work for me in Firefox 81 on macOS

You've already covered this one in your next comment.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.