1667173 - Recipient container grows horizontally when multiple addresses are dropped from the Contacts sidebar

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Alessandro Castellani [:aleca]]

Bug 1663057 introduced a regression that causes the input field to grow in size when addresses are dropped from the Contacts sidebar, resulting in a broken UI with an unwanted horizontal overflow.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1667173-recipients-area-growth.diff

Prevent the growth of the input field if the drop comes from the Address Book.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9177705 [details] [diff] [review]
1667173-recipients-area-growth.diff

Review of attachment 9177705 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWidgets.js
@@ +2212,5 @@
>        });
>  
>        this.addEventListener("drop", event => {
>          if (!event.dataTransfer.getData("text/pills")) {
> +          // Interrupt if dealing with addresses coming from the Contacts sidebar

nit: . at end.

But isn't it only the setting of size you want to skip, so I'm not sure the check is in the right place?

Comment 3

[Alessandro Castellani [:aleca]]

But isn't it only the setting of size you want to skip, so I'm not sure the check is in the right place?

If the addresses are coming from the sidebar we don't need to update the size of the input field as we don't need to accommodate strings since those addresses will be immediately added as pills.
The size check is only if pure text gets dropped in the input field, which needs to grow to accommodate the full text.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1667173-recipients-area-growth.diff

Comment updated.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9177735 [details] [diff] [review]
1667173-recipients-area-growth.diff

Review of attachment 9177735 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I'll clarify the comment a bit more and land it.

Comment 6

[Magnus Melin [:mkmelin]]

(78 will be affected once bug 1663057 goes to 78)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7c155c1b1aaf
Fix recipients area growing horizontally when addresses are dragged and dropped from the Contacts sidebar. r=mkmelin

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9177735 [details] [diff] [review]
1667173-recipients-area-growth.diff

[Approval Request Comment]
Pills polish.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9177735 [details] [diff] [review]
1667173-recipients-area-growth.diff

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/866097a0dbb8

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/866097a0dbb8

Comment 12

[WaltS48 [:walts48]]

Looks good to me testing the 82.0b3 release candidate on Ubuntu 18.04 LTS.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9177735 [details] [diff] [review]
1667173-recipients-area-growth.diff

[Triage Comment]
Approved for esr78

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/33127d7bcfe1