1667174 - Refactor RotorRules.mm to avoid duplication of checks in Match function

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Morgan Reschenberg [:morgan]]

There are a series of checks we have to do on every node we pass into a RotorRule, regardless of the later check we do to determine if it is a key match. We should abstract the checks we do on everything into some other virtual function/parent class so there's less code copying in these rules.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1667174: Create RotorRule base class to abstract checks duplicated across current rotor rules r?eeejay

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d9d32b08317
Create RotorRule base class to abstract checks duplicated across current rotor rules r=eeejay

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for OS X bustages on MOXSearchInfo.mm.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=9cdbf4e04e1980201fe33114f6296857f321a14f&searchStr=osx&selectedTaskRun=LX86qR5mSo-g_PF9IfR4ag.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=316936096&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/782c54a1b78e16483e4683b235d7ba82c7a507dd

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffb3a4a135ae
Create RotorRule base class to abstract checks duplicated across current rotor rules r=eeejay

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ffb3a4a135ae