Closed
Bug 166722
Opened 23 years ago
Closed 23 years ago
Compiler warnings in blapitest.c
Categories
(NSS :: Tools, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wtc, Assigned: bugz)
Details
Attachments
(1 file, 1 obsolete file)
|
5.38 KB,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
When compiling NSS under gcc on Linux, we get the following
compiler warnings in blapitest.c:
blapitest.c: In function `bltest_dsa_init':
blapitest.c:1089: warning: assignment from incompatible pointer type
blapitest.c:1105: warning: assignment from incompatible pointer type
(This bug report refers to rev. 1.34 of blapitest.c.)
|
Assignee | |
Comment 1•23 years ago
|
||
rsa takes fixed-size buffers, dsa takes SECItems...
|
Reporter | |
Comment 2•23 years ago
|
||
Comment on attachment 97984 [details] [diff] [review]
fix warnings
Ian, thanks for the fix. Your fix is correct. I'd like
to suggest two (stylistic) changes.
1. Declare the 'input' argument of bltestPubKeyCipherFn
with 'const', i.e., const SECItem *input.
2. Use dsa_SignDigest and dsa_VerifyDigest instead of
dsa_signDigest and dsa_verifyDigest.
Attachment #97984 -
Flags: needs-work+
|
|
Assignee | |
Comment 3•23 years ago
|
||
can't do (2), libfreebl.a has the symbol dsa_SignDigest, and bltest links
statically.
Attachment #97984 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 4•23 years ago
|
||
Comment on attachment 98001 [details] [diff] [review]
rev 2, also has stuff from another bug
r=wtc.
Maybe we should make the dsa_SignDigest and dsa_VerifyDigest
functions in libfreebl.a static?
Attachment #98001 -
Flags: review+
|
|
Assignee | |
Comment 5•23 years ago
|
||
done. fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•