1667288 - [moznetwork] get_ip() may return loopback address under python 3

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Geoff Brown [:gbrown]]

I hit this running android mochitests under python 3: moznetwork.get_ip() returns the loopback address, 127.0.0.1, rather than the normal IP, subsequently causing trouble for remote mochitests.

I have a simple solution.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: Bug 1667288 - [moznetwork] Ensure interface names returned by _get_interface_list are strings, even on python 3; r=

Currently on my Ubuntu laptop, when running under python 3, _get_interface_list() returns a list
of (byte, string), like (b'lo', '127.0.0.1') which is both inconsistent and troublesome for name
comparisons like
https://searchfox.org/mozilla-central/rev/89d33e1c3b0a57a9377b4815c2f4b58d933b7c32/testing/mozbase/moznetwork/moznetwork/moznetwork.py#145.
Let's return (string, string) instead, regardless of py2/3.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b99e823861d8
[moznetwork] Ensure interface names returned by _get_interface_list are strings, even on python 3; r=bc

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b99e823861d8