1667439 - `DOM_Fullscreen` is not a valid wakelock topic

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alastor Wu [:alwu]]

We handle wakelock topic in nsAppShell in each different platform but we didn't handle DOM_Fullscreen, so this wakelock actually didn't take effect.

Someone needs to take a look if we still need this wakelock or not. Currently wakelock would only be correctly request for media playback.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

It seems bug 805017 wanted to use wake lock when using Fullscreen API. But since:

1. the spec does not require it
2. Chrome does not neither on Android nor Windows
3. Gecko also actually didn't

I think we can safely remove it.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

There is a suggestion to spec and implement this: https://github.com/whatwg/fullscreen/issues/185

Comment 3

[Alastor Wu [:alwu]]

(In reply to Kagami :saschanaz from comment #1)

It seems bug 805017 wanted to use wake lock when using Fullscreen API. But since:

1. the spec does not require it
2. Chrome does not neither on Android nor Windows
3. Gecko also actually didn't

I think we can safely remove it.

Thank you, I am going to remove this, which can help us to clean unnecessary code for our refactoring preparation. If in the future we still want to add a wakelock for fullscreen, feel free to file another bug and block our meta bug.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1667439 - remove invalid wakelock for 'DOM_Fullscreen'.

Remove this invalid wakelock because our wakelock system doesn't handle this topic.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41ba0094d57c
remove invalid wakelock for 'DOM_Fullscreen'. r=saschanaz

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/41ba0094d57c