Closed Bug 1667473 Opened 4 years ago Closed 4 years ago

Fix uses of format with print in AWSY

Categories

(Testing :: AWSY, defect, P3)

Default
defect

Tracking

(firefox-esr78 unaffected, firefox82 unaffected, firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox82 --- unaffected
firefox83 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

There's a few places in AWSY that incorrectly converted the combination of print and format to be Python 3 compatible: print("port {} error {}").format(port, error). When I hit one of these locally, it complained about passing None into format, presumably because the print is run, then returns None, then that gets format called on it.'"

I happened to hit this because I'm working on a new AWSY test and my test is buggy. These are mostly in error messages.

These weren't noticed before because these are problems either in error
messages, or in the logging for a top-level script we don't run.

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/414d825ecec0
part 1 - Fix uses of format with print in AWSY. r=perftest-reviewers,Bebe
https://hg.mozilla.org/integration/autoland/rev/8717084e0d91
part 2 - Fix some AWSY typos. r=perftest-reviewers,Bebe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: