Closed Bug 1667486 Opened 4 years ago Closed 4 years ago

Avoid using CUPS localization names for paper sizes which we already have a name for

Categories

(Core :: Printing: Setup, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: alaskanemily, Assigned: alaskanemily)

Details

(Whiteboard: [print2020_v83][old-ui-] )

Attachments

(2 files)

This would make CUPS printers consistent with the fallback paper size list, and would also potentially avoid an additional connection in nsPrinterCUPS::CreateDefaultSettings.

This also makes the paper size data constexpr data. The localized paper data is
held in a RefPtr as it will be shared with the printers created by the printers
when we start using localized PWG names where possible.

This should be able to avoid creating a printer-specific HTTP connection in
nsPrinterCUPS::DefaultSettings when the paper size is a PWG-recognized size.

Attachment #9178006 - Attachment description: Bug 1667486 part 1 - Make PWG paper sizes public to nsPaper, localize the the sizes only once in nsPrinterListBase → Bug 1667486 part 1 - Make PWG paper sizes public to nsPaper, localize the sizes only once in nsPrinterListBase
Attachment #9178007 - Attachment description: Bug 1667486 part 2 - Localize PWG paper sizes with nsPrinterCUPS when possible → Bug 1667486 part 2 - Localize PWG paper sizes with nsPrinterCUPS when possible
Attachment #9178006 - Attachment description: Bug 1667486 part 1 - Make PWG paper sizes public to nsPaper, localize the sizes only once in nsPrinterListBase → Bug 1667486 part 1 - Make fallback paper sizes public to nsPaper, localize the sizes only once in nsPrinterListBase
Attachment #9178007 - Attachment description: Bug 1667486 part 2 - Localize PWG paper sizes with nsPrinterCUPS when possible → Bug 1667486 part 2 - Use our own localization for nsPrinterCUPS paper sizes when possible
Pushed by emcdonough@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd04da72d97d
part 1 - Make fallback paper sizes public to nsPaper, localize the sizes only once in nsPrinterListBase r=jwatt,emilio
https://hg.mozilla.org/integration/autoland/rev/543bb986a65e
part 2 - Use our own localization for nsPrinterCUPS paper sizes when possible r=emilio
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: