[wpt-sync] Sync PR 25804 - Only first run should consider run's offset to compute run's start
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox83 fixed)
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 25804 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/25804
Details from upstream follow.
b'Javier Fern\xc3\xa1ndez Garc\xc3\xada-Boente <jfernandez@igalia.com>' wrote:
Only first run should consider run's offset to compute run's start
The logic implemented in CreateViewsForResult tries to create a new
shape result based on a new range to be appled to a source ShapeResult.When the source result has more than one part, we shouldn't subtract
the the OffsetToRunStartIndex to the already computed part_start, which
already considers the source ShapeResult's offset.The second run has an offset that may be equal to the part_start,
resulting in 0 as index for the run_start. This makes the adjusted_start
computed later to use always the start_index, which can be smaller than
the part_start.This scenario leads to the DCHECK violation described in issue 1130153,
since it generates parts longer than expected, due to the incorrect
adjusted_start value.Bug: 1130153
Change-Id: Id5dd505baf1f990d2fe7a9406e191979cbd6b9f6
Reviewed-on: https://chromium-review.googlesource.com/2431523
WPT-Export-Revision: e10a5b883e70ab1aaecb545557e84d0bbd45484f
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7899d94988182ef64e52adef6bce920a193f37f
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
PASS: 1
Safari
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/313bd552525f [wpt PR 25804] - The adjusted_start must be computed based on the part_start, a=testonly
Comment 4•4 years ago
|
||
bugherder |
Description
•