1667602 - Compose window UI overflows horizontally when long string/multiple csv addresses are pasted after existing pills

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P2)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Unwanted horizontal UI overflow after pasting multiple CSV addresses

+++ This bug was initially created as a clone of Bug #1667173 +++

STR

1. Compose and have a few pills in To.
2. Paste multiple comma-separated addresses into the address input after existing pills.

Actual result

• Broken UI with an unwanted horizontal overflow beyond window width with lots of invisible addresses
• It's very hard for the user to figure out the next step, because focus/cursor are also hidden in the overflow.

Expected

• No horizontal overflow
• ideally, make the input multi-line for this scenario
• otherwise, overflow inside the input and keep the cursor position visible.

This is a regression (perhaps also from bug 1663057)

(In reply to Thomas D. (:thomas8) from Bug 1666463 Comment 13)

Also there's a variant of bug 1667173 which isn't covered yet: Pasting
string of CSV which is longer than the rest of the addressing row will
expand the row horizontally beyond the screen. Guess they could share the
same resizing code in a function. Or maybe we could just listen for input
event on the input and attach the resizing there, which hopefully also
covers the drop.

Comment 1

[Thomas D. (:thomas8)]

Not sure if this was regressed by bug 1663057, so let's make that see-also.

Comment 2

[Alessandro Castellani [:aleca]]

Unfortunately this is not a regression as it always had this issue since first implementation.
Fix coming up!

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1667602-input-size.diff

This should do it, and it shouldn't interfere with any other scenario.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9178601 [details] [diff] [review]
1667602-input-size.diff

Redirecting this review to Magnus since Thomas is busy with other tasks.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9178601 [details] [diff] [review]
1667602-input-size.diff

Review of attachment 9178601 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWidgets.js
@@ +2128,5 @@
> +          // We need to be sure the new size of the input field doesn't exceed
> +          // its container width. This might happen if the user pastes a very
> +          // long string with multiple addresses when pills are already present.
> +          if (
> +            input.getAttribute("size") > 1 &&

do we ever set it to 0 or minus values?

Comment 6

[Alessandro Castellani [:aleca]]

No, we always reset this to 1 after a pill is created as we need to force its size to properly stay inline the recipients container, otherwise the default sizing coming from toolkit will create visual inconsistencies (eg. a tall recipients container even if all the pills fit in a single row).

Comment 7

[Magnus Melin [:mkmelin]]

I guess then I'm asking does that line do anything useful?

Comment 8

[Alessandro Castellani [:aleca]]

Mh, I guess not, and we can solely rely on the width condition.
Let me check if it works as expected.

Comment 9

[Alessandro Castellani [:aleca]]

Attachment: 1667602-input-size.diff

Yup, that works.

Comment 10

[Magnus Melin [:mkmelin]]

I don't seem to reproduce this bug for paste.
For dragging such text there's still at least a temporary issue that the field grows a lot, then shrinks back again after pill creation

Comment 11

[Thomas D. (:thomas8)]

(In reply to Magnus Melin [:mkmelin] from comment #10)

I don't seem to reproduce this bug for paste.

Maybe this?

• condition 1: pasted string must be longer than the available total width of the addressing row. Easier to see on reduced/small window width.
• condition 2: paste must occur in a line which is almost filled with pills, so the address input is on the far right of the address row.
• strange: does not occur for pasting on the far left, even when the string is longer than the address row.

Here's a sample string for pasting (you can paste two times):

Jane Doe <[e-mail]>, John Doe <[e-mail]>, Susi Sommer <[e-mail]>, [e-mail], [e-mail], Jane Doe <[e-mail]>, John Doe <[e-mail]>, Susi Sommer <[e-mail]>, Peter Petermann-Neufeld <[e-mail]>, Paul public <[e-mail]>

Mind that somehow when pasting too many duplicate addresses, there seems to be some filtering going on.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9179354 [details] [diff] [review]
1667602-input-size.diff

Review of attachment 9179354 [details] [diff] [review]:
-----------------------------------------------------------------

The case of drag'n'dropping instead of pasting still need fixing.

Comment 13

[Alessandro Castellani [:aleca]]

Attachment: 1667602-input-size.diff

This should take care of all the scenarios.

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 9179737 [details] [diff] [review]
1667602-input-size.diff

Review of attachment 9179737 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/17b4cd755c55
Fix recipient input field not updating size when a straing is pasted. r=mkmelin DONTBUILD

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 9179737 [details] [diff] [review]
1667602-input-size.diff

[Approval Request Comment]
Pills polish

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9179737 [details] [diff] [review]
1667602-input-size.diff

[Triage Comment]
Approved for beta

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4fede0d63a34

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4fede0d63a34

Comment 20

[WaltS48 [:walts48]]

Looks good to me testing the 82.0b3 release candidate on Ubuntu 18.04 LTS.

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9179737 [details] [diff] [review]
1667602-input-size.diff

[Triage Comment]
Approved for esr78

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/6bfd7eb77e79