Closed Bug 1667626 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 25805 - [css-flex] Pass a ConstraintSpace to ortho_table.ComputeMinMaxSizes()

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25805 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25805
Details from upstream follow.

b'David Grogan <dgrogan@chromium.org>' wrote:

[css-flex] Pass a ConstraintSpace to ortho_table.ComputeMinMaxSizes()

ComputeMinMaxSizes needs a ConstraintSpace when the child is not in a
parallel writing mode. Flex wasn't providing one when it retrieved a
table's intrinsic min size.

Before this bug was introduced, flex was calling
ComputeMinAndMaxContentContribution(..., table, ...) instead of
table.ComputeMinMaxSizes(...). ComputeMinAndMaxContentContribution
builds its own ConstraintSpace for ortho items, so flex didn't need to
provide one.

Fixed: 1131890
Change-Id: Ie5a4eac97e4a6a2e96104397bd5c5ec483d40e78
Reviewed-on: https://chromium-review.googlesource.com/2433594
WPT-Export-Revision: d971c94bd0901c1927a42f0b9fa3d80a03de527a

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-flexbox/ortho-table-item-001.html: FAIL (Chrome: CRASH, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eba41c8e77ba
[wpt PR 25805] - [css-flex] Pass a ConstraintSpace to ortho_table.ComputeMinMaxSizes(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/339856f27628
[wpt PR 25805] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.