1667656 - Continue cleaning up layers logging code

Status: RESOLVED FIXED

(Core :: Graphics: Layers, task, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1667176 +++

I started on some patches for bug 1666802, but haven't done it all yet. I want to land them incrementally rather than have a 100-patch series so I'm spinning out sub-bugs as I go.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef4ae582b700762ac7dc83595b8e75dd6e71b231&selectedTaskRun=It-RwTU1Rs6AvBkb2i8iZA.0

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Use ostream operator instead of AppendToString for PointTyped. r?mattwoodrow

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Remove unused Point3DTyped AppendToString function. r?mattwoodrow

Depends on D91517

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Replace AppendToString of IntPointTyped with ostream usage. r?mattwoodrow

Depends on D91518

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Replace AppendToString of RectTyped with ostream usage. r?mattwoodrow

Depends on D91519

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Replace AppendToString of IntRectTyped with ostream usage. r?mattwoodrow

Depends on D91520

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Replace AppendToString of RectAbsoluteTyped with ostream usage. r?mattwoodrow

Depends on D91521

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Remove unused IntRectAbsoluteTyped AppendToString function. r?mattwoodrow

Depends on D91522

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Replace AppendToString of nsSize with ostream usage. r?mattwoodrow

Depends on D91523

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Replace AppendToString of nsRegion with ostream usage. r?mattwoodrow

Apparently a bunch of Stringify(nsRect) sites were getting converted to
Stringify(nsRegion(nsRect)) due to the the nsRegion implicit constructor, so
this updates those too.

Depends on D91524

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1667656 - Replace AppendToString of nsIntRegion with ostream usage. r?mattwoodrow

As with nsRegion, nsIntRegion has an implicit constructor for IntRect and so
some dangling Stringify(IntRect) sites also get converted here.

Depends on D91525

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67ac8857fac0
Use ostream operator instead of AppendToString for PointTyped. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/b1785ca5c008
Remove unused Point3DTyped AppendToString function. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/f90514d94891
Replace AppendToString of IntPointTyped with ostream usage. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/102d19749009
Replace AppendToString of RectTyped with ostream usage. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/f96d6169dad7
Replace AppendToString of IntRectTyped with ostream usage. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/82e59358644e
Replace AppendToString of RectAbsoluteTyped with ostream usage. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/35229b94dda0
Remove unused IntRectAbsoluteTyped AppendToString function. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/dbdb25f76b66
Replace AppendToString of nsSize with ostream usage. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/1f509962b47d
Replace AppendToString of nsRegion with ostream usage. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/45c484bdca6d
Replace AppendToString of nsIntRegion with ostream usage. r=mattwoodrow

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/67ac8857fac0
https://hg.mozilla.org/mozilla-central/rev/b1785ca5c008
https://hg.mozilla.org/mozilla-central/rev/f90514d94891
https://hg.mozilla.org/mozilla-central/rev/102d19749009
https://hg.mozilla.org/mozilla-central/rev/f96d6169dad7
https://hg.mozilla.org/mozilla-central/rev/82e59358644e
https://hg.mozilla.org/mozilla-central/rev/35229b94dda0
https://hg.mozilla.org/mozilla-central/rev/dbdb25f76b66
https://hg.mozilla.org/mozilla-central/rev/1f509962b47d
https://hg.mozilla.org/mozilla-central/rev/45c484bdca6d