1667668 - Download section of https://www.resilio.com/individuals/ has broken layout in Nightly 83

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect, P1)

Description

[lolrepeatlol]

Attachment: Screenshot_2020-09-27 File Sync Software - Sync Home Resilio Sync.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

I went to https://www.resilio.com/individuals/.

Actual results:

The Downloads section of the website showed a broken "Desktop Downloads" layout, with a stretched Tux and text not being where it's supposed to be.

Expected results:

The layout should have been normal, like it is in Beta, with no stretched Tux and text in the correct places.

Note: this happens in a fresh profile as well.

Comment 1

[lolrepeatlol]

This has been occurring for a few days (sorry for not reporting earlier) but just in case it's still of interest, here's my build ID: 20200927094310.

Comment 2

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=095c8aec7254d999ce27a3f0c531ecd965f87f3b&tochange=fe228ad057f67075b8dbb39eb9cfe34cde30cad3

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1316534

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1667668 Part 1 - Add verbose flex log to print various size suggestions.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1667668 Part 2 - Use main max size to clamp specified size suggestion only if main size is definite.

flex-aspect-ratio-img-row-012.html is the test failed without this
patch. flex-aspect-ratio-img-column-016.html is added for symmetry (Note
column-012.html to column-015.html is occupied in upstream).

Depends on D91678

Comment 6

[Daniel Holbert [:dholbert]]

I ran into what I think is this same issue at https://www.amazon.com/stores/Guardian+Drain+Lock/page/CAD6696C-DD42-4A1A-B8C2-DB2D20425689

If you scroll down about 2/3 of the way, there are some wide listings whose "Prime" logos (to the right of their star-ratings) are stretched in Nightly, I think due to this bug. (There's a max-width on those logos, and the stretching goes away if I remove it in devtools.)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac64a4e5582b
Part 1 - Add verbose flex log to print various size suggestions. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/55175b2bbcf8
Part 2 - Use main max size to clamp specified size suggestion only if main size is definite. r=dholbert

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25844 for changes under testing/web-platform/tests

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ac64a4e5582b
https://hg.mozilla.org/mozilla-central/rev/55175b2bbcf8

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot