1667729 - Large number of unreachable-code warnings in gl.cc (triggered from build.rs)

Status: NEW

(Core :: Graphics: WebRender, defect)

Description

[Jan-Erik Rediger [:janerik]]

Attachment: log.txt

The assert code in gfx/wr/swgl/src/gl.cc is triggering a bunch of unreachable-code warnings.
That file is compiled from gfx/wr/swgl/build.rs and thus warnings are not caught by mach.

A bit annoying if one tries to find their own errors and warnings in the output.
We should probably silence those warnings.

Comment 1

[Jan-Erik Rediger [:janerik]]

Locally I applied this just to stop it from annoying me right now:

diff --git gfx/wr/swgl/build.rs gfx/wr/swgl/build.rs
index 62c09ba7f310b..894079799d722 100644
--- gfx/wr/swgl/build.rs
+++ gfx/wr/swgl/build.rs
@@ -143,6 +143,7 @@ fn main() {
         .flag("-fno-exceptions")
         .flag("-fno-rtti")
         .flag("-fno-math-errno")
+        .flag("-Wno-unreachable-code")
         .define("_GLIBCXX_USE_CXX11_ABI", Some("0"))
         .include(shader_dir)
         .include("src")