1667737 - Duplicated requests and multiselection issues

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

STR:

1. Load http://janodvarko.cz/tests/fission/case6/index.html
2. Open DevTools Toolbox and select the Network panel
3. Reload the page
4. Note that all requests are displayed three times -> BUG
5. Try to select one of the duplicated requests, three requests are selected at the same time -> BUG

Also requests, coming from the top level document seems to be incomplete.
See the attached screenshot.

This only happens with Fission

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hubert, can you reproduce this?

Honza

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:Honza, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

In case of troubles to reproduce the issue, use back/forward buttons.

STR:

1. Load http://janodvarko.cz/tests/fission/case6/index.html
2. Open DevTools Toolbox and select the Network panel
3. Click the Back button (Firefox toolbar)
4. Click the Forward button (Firefox toolbar)
5. All requests are multiplied -> BUG

The more you repeat steps #3 and #4 the more requests is multiplied.

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can reproduce even without Fission.

Honza

Comment 5

[Hubert Boma Manilla (:bomsy)]

Yes i can reproduce. I think it might be related to the issue with Bug 1667225

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There is one more case reproducible with Fission only, but feels like the root issue could be the same:

1. Load http://janodvarko.cz/tests/fission/case1/index.html
2. Open DevTools Toolbox and select the Network panel
3. Click the this same page link that loads the same page from different domain (causing Fission target-switch)
4. Reload the page.
5. All requests are multiplied -> BUG

Honza

Comment 7

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1667737 - Investigating duplicating request coming from the cache

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

One more case reproducible with Fission only:

1. Load https://farooqar.github.io/sse-echo/
2. Open DevTools Toolbox and select the Network panel
3. Click the "Connect" button.
4. The new request is there 3 times -> BUG

Honza

Comment 9

[Alexandre Poirot [:ochameau]]

This has actually been made much more visible since bug 1663649 landed.

This issue relates to target-swiching. If you navigate between two processes, you will start seeing this issue.
This is because we start listening multiple times to the NETWORK_EVENT resource, everytime we have a top level target swiching.

Comment 10

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1befc169416ff0b57f902d3195ed642b5e056a3

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1667737 - [devtools] Avoid registering resource listener twice on target switching from netmonitor.

We should register the resource listeners only once.
ResourceWatcher will automatically handle re-registering the per-target listener for us.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed211f4f71d2
[devtools] Avoid registering resource listener twice on target switching from netmonitor. r=Honza

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ed211f4f71d2