Remove unused _IMPL_NS_APPSHELL defines

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
16 years ago
13 years ago

People

(Reporter: Stephen Walker, Assigned: Samir Gehani)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

15.82 KB, patch
Brian Ryner (not reading)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
_IMPL_NS_APPSHELL & NS_APPSHELL are defined in a few places, but they don't do 
anything. nsappshell.h is even built anymore, it can be removed completely, 
nothing uses nsIDOMXPConnectFactory.h, it can be removed completely, and the 
function that uses NS_APPSHELL in nsICmdLineService.idl isn't ever called.

A large amount of mac prefix files can also be completely removed:
/modules/mpfilelocprovider/macbuild/mpfilelocPrefix.h
/modules/mpfilelocprovider/macbuild/mpfilelocPrefix_debug.h
/xpfe/appshell/macbuild/AppShellSharedPrefix_debug.h
/xpfe/appshell/macbuild/AppShellSharedPrefix.h
/xpfe/components/bookmarks/macbuild/BookmarksPrefix.h
/xpfe/components/bookmarks/macbuild/BookmarksPrefix_debug.h
/xpfe/components/directory/DirectoryPrefix.h
/xpfe/components/directory/DirectoryPrefix_debug.h
/xpfe/components/find/macbuild/FindComponentPrefix.h
/xpfe/components/find/macbuild/FindComponentPrefix_debug.h
/xpfe/components/history/macbuild/historyPrefix_debug.h
/xpfe/components/history/macbuild/historyPrefix.h
/xpfe/components/prefwindow/macbuild/prefwindowPrefix.h
/xpfe/components/prefwindow/macbuild/prefwindowPrefix_debug.h
/xpfe/components/regviewer/RegViewerPrefix.h
/xpfe/components/regviewer/RegViewerPrefix_debug.h
/xpfe/components/related/macbuild/RelatedPrefix_debug.h
/xpfe/components/related/macbuild/RelatedPrefix.h
/xpfe/components/search/macbuild/SearchPrefix_debug.h
/xpfe/components/search/macbuild/SearchPrefix.h
/xpfe/components/shistory/macbuild/shistoryPrefix_debug.h
/xpfe/components/shistory/macbuild/shistoryPrefix.h
/xpfe/components/download-manager/macbuild/DownloadManagerPrefix_debug.h
/xpfe/components/download-manager/macbuild/DownloadManagerPrefix.h
(Reporter)

Comment 1

16 years ago
Created attachment 97904 [details] [diff] [review]
patch
-> XP Apps
Assignee: walk84 → sgehani
Component: Build Config → XP Apps
Keywords: patch
QA Contact: granrose → paw
Comment on attachment 97904 [details] [diff] [review]
patch

r=bryner
Attachment #97904 - Flags: review+

Comment 4

16 years ago
i'm not going to remove nsappshell.h yet, sorry, I need to find out why
cvsguess.cgi can't find it (bug 170505).
Depends on: 170505
Product: Core → Mozilla Application Suite

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 5

13 years ago
(In reply to comment #4)
> i'm not going to remove nsappshell.h yet, sorry, I need to find out why
> cvsguess.cgi can't find it (bug 170505).

Now that you've found out, will it go?
You need to log in before you can comment on or make changes to this bug.