1668054 - Include the computed FissionAutostart value in the telemetry environment

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

This was split off from bug 1667426, and tracks adding the fissionEnabled boolean to the telemetry environment, replacing the "fission.autostart" pref value in userPrefs.

This value needs to be reported, rather than the dynamic value of the "fission.autostart" pref, in order to correctly reflect the value of "fission.autostart" for a particular browsing session, which may be impacted by other values than the pref.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1668054 - Use computed fission enabled status in TelemetryEnvironment,

This new fissionEnabled flag in settings replaces the previous reporting of the
"fission.autostart" pref value from userPrefs. This is needed in order to
correctly reflect the fission enabled status for a particular browsing session,
as the pref may change at runtime, or the enabled status may be impacted by
other factors than the pref's current value.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: data review request

Comment 3

[Nika Layzell [:nika] (ni? for response)]

According to a conversation I had with :chutten, this may require some help from the data engineering team in order to implement, as adding a field to the telemetry environment may require changing a server-side schema. This may just require adding a new field to the schema here, like e10sEnabled: https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/8e220b6ce2ff90f865ff9bc21f8e21c05576c87c/templates/include/telemetry/environment.1.schema.json#L516-L519, but I don't know enough to be certain.

(For context, this patch is adding a boolean fissionEnabled field to the "settings" section of the telemetry environment, much like the older e10sEnabled field)

ni? :mreid for more information

Comment 4

[Arkadiusz Komarzewski [:akomar]]

(In reply to Nika Layzell [:nika] (ni? for response) from comment #3)

According to a conversation I had with :chutten, this may require some help from the data engineering team in order to implement, as adding a field to the telemetry environment may require changing a server-side schema. This may just require adding a new field to the schema here, like e10sEnabled: https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/8e220b6ce2ff90f865ff9bc21f8e21c05576c87c/templates/include/telemetry/environment.1.schema.json#L516-L519, but I don't know enough to be certain.

(For context, this patch is adding a boolean fissionEnabled field to the "settings" section of the telemetry environment, much like the older e10sEnabled field)

ni? :mreid for more information

That is mostly correct - we will add this field to the schema like e10sEnabled, although this is not a blocker for landing the pref on the client (it will just show up under additional_properties in BigQuery table).

Comment 5

[Chris H-C :chutten]

Comment on attachment 9178516 [details]
data review request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nika is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a0ad7d6a16b
Use computed fission enabled status in TelemetryEnvironment, r=kmag,chutten

Comment 7

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1668054, bug 1667426) for Browser-chrome failure in toolkit/modules/tests/browser/browser_Troubleshoot.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317322468&repo=autoland&lineNumber=8855

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=0a0ad7d6a16b9cb5d72b0bbb388409054cc3d919

Backout:
https://hg.mozilla.org/integration/autoland/rev/0acb34a4e5f35fe24be33cb1fff95502bf2e386a

Comment 8

[Andrew McCreight [:mccr8]]

I'll work on fixing the test failure and relanding.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8295181929a
Use computed fission enabled status in TelemetryEnvironment, r=kmag,chutten

Comment 10

[Andrew McCreight [:mccr8]]

(In reply to Andrew McCreight [:mccr8] from comment #8)

I'll work on fixing the test failure and relanding.

Never mind. Looks like Nika fixed it.

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d8295181929a

Comment 12

[Mark Reid [:mreid]]

I filed a follow up Bug 1669208 to take care of adding this new field to the schema (per comment 4).