1668056 - Bailout profiler markers should be text markers

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[Florian Quèze [:florian]]

Currently each Bailout marker has its own line in the profiler UI, which clutters the marker chart.

Bug 976260 originally introduced markers there. Bug 1329921 suggests converting them to structured data, which is difficult given that GeckoProfiler.h can't be included directly. I think converting these markers to text markers would be a good first step.

Here are the current bailout markers on a startup profile on a slow Windows machine: https://share.firefox.dev/3kYN9Mp
Here are bailout markers with my patch applied on a startup profile on my local mac build: https://share.firefox.dev/3jeqpHR

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1668056 - Bailout profiler markers should be text markers. r=jandem,gerald

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17e142537e65
Bailout profiler markers should be text markers. r=jandem,gerald

Comment 3

[Florian Quèze [:florian]]

It turns out the profiler front-end code had a special handling for these markers at https://github.com/firefox-devtools/profiler/blob/4748485d901af0d1768495ddde606bcb6b4d68cb/src/profile-logic/marker-data.js#L250
However, that code broke for the Bailout markers when bug 1649201 changed the output of the BailoutKindString function from "Bailout_<kind>" to "BailoutKind::<kind>".

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/17e142537e65