1668100 - AXUIElementsForSearchPredicate should use target element as root for search

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

It seems that VoiceOver expects search predicate calls to be bound by the target element they are called on. If they are not, VO goes into an endless loop because it expects the results of the search to be descendants of the target.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1668100 - Make target root for AXUIElementsForSearchPredicate. r?morgan!

Instead of having the web area be the implicit root, the search results should
exclusively be descendants of the target element that the search is called on.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22c636393a44
Make target root for AXUIElementsForSearchPredicate. r=morgan

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/22c636393a44

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1657418

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

Do we need this on beta82?

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1668100 - Make target root for AXUIElementsForSearchPredicate. r=morgan!

Instead of having the web area be the implicit root, the search results should
exclusively be descendants of the target element that the search is called on.

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 9180221 [details]
Bug 1668100 - Make target root for AXUIElementsForSearchPredicate. r=morgan!

Beta/Release Uplift Approval Request

• User impact if declined: VoiceOver cursor will not work in many websites
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This isn't a one liner, but it also has tests.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9180221 [details]
Bug 1668100 - Make target root for AXUIElementsForSearchPredicate. r=morgan!

approved for 82.0b9

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/09b532db3920

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

This didn't make b9 after all, but should be in today's 82 rc1.