1668248 - Check string type max capacity before attempting to adopt memory in `nsDOMDataChannel::Send`

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Paul Adenot (:padenot)]

Strings can have less capacity than arraybuffers, depending on the type.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1668248 - Use fallible string operations in nsDOMDataChannel::Send. r?bwc

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1668248 - Use fallible string operations in WebSocket::Send. r?valentin

Depends on D91928

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1668248 - Test that DataChannel.send fails gracefully when the argument is too big. r?bwc

Depends on D91929

Comment 4

[Lennart Grahl [:lgrahl]]

Apologies for the tweet but I filed that three years ago, so I figured that's okay to post...
https://bugzilla.mozilla.org/show_bug.cgi?id=1382779

Comment 5

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee2bd85bb71e65a7e103b883272ae5a45f614d98

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaa857f4564d
Use fallible string operations in nsDOMDataChannel::Send. r=bwc
https://hg.mozilla.org/integration/autoland/rev/9f6b8aa11110
Use fallible string operations in WebSocket::Send. r=valentin
https://hg.mozilla.org/integration/autoland/rev/3097e934187b
Test that DataChannel.send fails gracefully when the argument is too big. r=bwc

Comment 8

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1668248) for Devtools failures in devtools/shared/resources/tests/browser_resources_websocket.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317308592&repo=autoland&lineNumber=4944

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=2a72b40ba26afd7c43f0bb39f25274683a41171f

Backout:
https://hg.mozilla.org/integration/autoland/rev/70590d692947770cf1b09ff0d0d917b0e47afe95

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f557d78a36d
Use fallible string operations in nsDOMDataChannel::Send. r=bwc
https://hg.mozilla.org/integration/autoland/rev/fc35315d5e8e
Use fallible string operations in WebSocket::Send. r=valentin
https://hg.mozilla.org/integration/autoland/rev/cf7ae63672c8
Test that DataChannel.send fails gracefully when the argument is too big. r=bwc

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f557d78a36d
https://hg.mozilla.org/mozilla-central/rev/fc35315d5e8e
https://hg.mozilla.org/mozilla-central/rev/cf7ae63672c8