1668260 - The "Suggested Tags" and the "Similar Stories" sections from the "Saved to Pocket" doorhanger are removed if any key is pressed while the tags input field is focused

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 82.0b5 - Build ID: 20200929175845
• Firefox Nightly 83.0a1 - Build ID: 20200929213959

[Affected Platforms]:

• Windows 10 x64
• macOS 10.15
• Ubuntu 18.04 x64

[Prerequisites]:

• You are logged in to Pocket.
• Have the "extensions.pocket.onSaveRecs" pref set to "true" in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Click the "Save to Pocket" doorhager and focus the tags input field.
3. Press any key and observe the behavior.

[Expected result]:

• The character is added to the tags input field.

[Actual result]:

• The character is added to the tags input field, but the "Suggested Tags" and the "Similar Stories" sections are dismissed.

[Notes]:

• This issue is not reproducible on Firefox Release 81.0 where the "Similar Stories" section is not present.
• Attached a screenshot of the issue.

Comment 1

[Scott [:thecount] Downe]

I took a look at this.

For the most part, this is intended.

The issue being, the doorhanger is in an iframe, and it's a lot of state to maintain to manually set the iframe height based on the content.

The easy solution is to, if you start inputting a tag, instead of updating the height (to ensure room for the drop down) we remove the non tag based content. (it's easy enough to bring back by opening the doorhanger again)

Not ideal, but works for now.

I did make this a bit better, where the premium tag box stay, and the recs only hide if the drop down opens, not when you start typing. I did this in bug 1668247

I'll keep this open for now, because at some point it would be nice to clean up the complexity in maintaining the element's height more. I imagine this needs a react rewrite of some sort to make sensible.

Comment 2

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (82.0b8 Build ID - 20201006142214) and the latest Firefox Nightly (83.0a1 Build ID - 20201008210150) installed, on Windows 10 x64, Ubuntu 18.04 x64, and Mac 10.15. It seems that this issue was fixed in bug 1668247 and I can confirm that the "Suggested Tags" and the "Similar Stories" sections from the "Saved to Pocket" doorhanger are no longer removed if any key is pressed while the tags input field is focused.

Considering the above I am closing this issue as RESOLVED-FIXED.

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

Based on the previous comment I am marking this issue as Verified.