Add a fix for the pending pings directories queries
Categories
(Data Platform and Tools :: Glean: SDK, defect, P1)
Tracking
(Not tracked)
People
(Reporter: brizental, Assigned: brizental)
Details
These queries will soon broken due to the bug I fixed in: https://github.com/mozilla/glean/pull/1236
tl;dr; We are recording the directory size in the incorrect memory unit and that is what the PR fixes, soon the correct data will start flowing in that will inevitably break the queries.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
I have added a fix, it's a bit involved, but it looks correct from the visualizations.
[:janerik] Would you mind double checking that the fix is correct?
Links to the queries:
- Fenix Stable (org.mozilla.firefox): Number of deleted pings vs. Max recorded pending pings directory size
- Fenix Nightly (org.mozilla.fenix): Number of deleted pings vs. Max recorded pending pings directory size
- Fenix Stable (org.mozilla.firefox): Monitor pending pings directory size
- Fenix Nightly (org.mozilla.fenix): Monitor pending pings directory size
I use the same logic for all of them: I separate all the entries from a version before the fix < 32.4.1 and all the entries after >= 32.4.1. Then I apply the correct transformation function to the values of each set and then join them.
I also chaged from scatter plot to box plot. I know that the box plot doesn't necessarily make sense in this case, but it looks similar to the scatter plot and doesn't freeze the browser while doing so. I expect that now that the data from stable is flowing in this would become a bigger issue.
|
||
Comment 2•5 years ago
|
||
The logic looks good. Guess we could remove that logic in like 2 or 3 versions (if by then we still monitor it).
Box plot looks fine, still carries enough information to inform us at a glance.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Jan-Erik Rediger [:janerik] from comment #2)
The logic looks good. Guess we could remove that logic in like 2 or 3 versions (if by then we still monitor it).
Box plot looks fine, still carries enough information to inform us at a glance.
I'll add a TODO comment to the query about this :)
Description
•