1668397 - [wpt-sync] Sync PR 25902 - WebXR: Add dynamic viewport scaling support

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25902 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25902
Details from upstream follow.

b'Klaus Weidner <[e-mail]>' wrote:

WebXR: Add dynamic viewport scaling support

Adds support for a per-view viewport scale factor, dynamically
configurable on a per-frame basis. The feature is controlled by the
WebXRViewportScale Blink feature, and can be enabled via
chrome://flags#webxr-incubations or the
--enable-features=WebXRIncubations command line flag.

See https://github.com/immersive-web/webxr/pull/1132/files
for the related spec changes.

This CL does not yet implement a recommended scale factor which is
an optional feature in the spec. The attribute just returns
base::nullopt for now.

In addition to the Blink experimental feature flag, the device backends
also need to opt in by setting XRSession.supports_viewport_scaling
via mojo response. Currently, only the GVR device enables the feature.

Bug: 1133381
Change-Id: I5ccf3fd613eb78475e1f4512025cc3eab6fd149d
Reviewed-on: https://chromium-review.googlesource.com/2438207
WPT-Export-Revision: 2d56387d16c3fea2def6b06664eba35bbba16a2e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 25902 applied with additional changes from upstream: 83739405b8b7ad3084b5c41a67c1c18ea174d4e7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7c6aed1f5738241b784aaa94333037b93143f43

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 14 subtests

Status Summary

Firefox

OK : 1
FAIL : 14

Chrome

TIMEOUT: 1
ERROR : 1
NOTRUN : 13

Safari

OK : 1
FAIL : 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xr_viewport_scale.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: OK)
requestViewportScale valid viewport for inline session: FAIL (Chrome: TIMEOUT, Safari: FAIL)
requestViewportScale valid viewport w/ null scale for inline session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale valid viewport w/ undefined scale for inline session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale valid viewport w/ very small scale for inline session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale applied next frame for inline session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale same frame for inline session: FAIL (Chrome: NOTRUN, Safari: FAIL)
recommendedViewportScale for inline session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale valid viewport for immersive-vr session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale valid viewport w/ null scale for immersive-vr session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale valid viewport w/ undefined scale for immersive-vr session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale valid viewport w/ very small scale for immersive-vr session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale applied next frame for immersive-vr session: FAIL (Chrome: NOTRUN, Safari: FAIL)
requestViewportScale same frame for immersive-vr session: FAIL (Chrome: NOTRUN, Safari: FAIL)
recommendedViewportScale for immersive-vr session: FAIL (Chrome: NOTRUN, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webxr/xr_viewport_scale.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: ERROR, Safari: OK)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01565772eaef
[wpt PR 25902] - WebXR: Add dynamic viewport scaling support, a=testonly
https://hg.mozilla.org/integration/autoland/rev/64ecfa5f2883
[wpt PR 25902] - Update wpt metadata, a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/01565772eaef
https://hg.mozilla.org/mozilla-central/rev/64ecfa5f2883