1668435 - vendor nimbus rust sdk into m-c

Status: RESOLVED WONTFIX

(Firefox :: Nimbus Desktop Client, task)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This bug is for vendoring the rust nimbus build into mozilla-central. I've filed it now so that Andrei and I can easily use phab to share work.

It's related to https://jira.mozilla.com/browse/EXP-419 among other things.

Stuff that we know we still need to do:

• fix uniffi template to emit C++ bindings that build without DEBUG
• figure out if uniffi Cargo.toml should switch from license_file to licenseor whether the build allow list needs to be a bit more liberal
• move SDK build glue patch after artifact landing patch so that bisecting works
• handle upstream dependency files that are too big (PRs, or make exceptions locally)
• split apart (at least) updating existing dependencies from addition of new dependencies into PRs that are at least reviewable if not ideally bisectable
• check dependency version pins and make sure they're up-to-date
• remove built_bindgen as suggested by eoger (he says it was a hack)
• make Nimbus not crash in constructor if called from wrong thread

Later (maybe):

• figure out threading/IO model for gecko_js
  ** Kate points out that our model may want to take existing preferences idioms into account if we can make migration of existing experimenting infra less painful (eg static pref stuff).
  ** maybe consider what glean does (ideally), or telemetry (possibly necessarily pragmatically)
  ** eventually will need to be able to get some cached experiment values quickly early in startup (talk to Kate)
  ** (maybe later) generate webidl artifacts at build time rather than checking them in

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor Nimbus Rust SDK into desktop

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - vendor nimbus-sdk into m-c, original patch by <[e-mail]>

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Executing Nimbus vendoring

Depends on D92172

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Stuff generated from nimbus-sdk by uniffi-bindgen with build patches

Depends on D92296

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Nimbus SDK build glue

Depends on D92296

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Add Nimbus artifacts generated by uniffi branch

Depends on D92537

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Add xpcshell port of test_fs_client.rs

Depends on D92538

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Update pinned rust deps for Nimbus/Uniffi compat

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor in pinned rust deps for Nimbus/UniFFI compat

Depends on D93448

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Add reference to uniffi dependency

Depends on D93449

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor in uniffi and dependencies

Depends on D93450

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - add Nimbus package reference and extern declaration

Depends on D93452

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - vendor in Nimbus and deps

Depends on D93453

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

For reasons not worth going into the revisions in this bug are all out of order. The top (parent) revision is https://phabricator.services.mozilla.com/D93448 and the rest are children of it.

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor in uniffi and dependencies

Depends on D93450

Comment 16

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - add nimbus-sdk + uniffi refs and various glue

Depends on D94411

Comment 17

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor in Nimbus + deps

Depends on D94412

Comment 18

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Update viaduct refs & downrev rusqlite

Comment 19

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor in upgraded Viaduct and downgraded Rusqlite

Depends on D95389

Comment 20

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor in uniffi and friends

Depends on D93450

Comment 21

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - Vendor in Nimbus SDK and friends

Depends on D94412

Comment 22

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1668435 - cargo.in changes from vendoring in various bits

Depends on D92539

Comment 23

[Dan Mosedale (:dmosedale, :dmose)]

Just an FYI, when one needs to generate the Nimbus artifacts using UniFFI, here's how:

cd uniffi-rs
# pull the uniffi PR locally; then do this:
cargo clean
cargo build
cd uniffi_bindgen
cargo run -- generate ../../nimbus-sdk/nimbus/src/nimbus.idl -l gecko_js -o ../../mozilla-central/toolkit/components/nimbus

Comment 24

[Dan Mosedale (:dmosedale, :dmose)]

This is obsolete; there is a different strategy now.