Open
Bug 1668618
Opened 5 years ago
Updated 5 years ago
Phabricator emails: send email when Lando makes changes to patch after landing
Categories
(Conduit :: Phabricator, enhancement, P3)
Conduit
Phabricator
Tracking
(Not tracked)
NEW
People
(Reporter: mhentges, Unassigned)
Details
(Keywords: conduit-triaged)
In some cases (e.g.: code formatting), Lando will adjust a patch before landing.
It is useful for authors and reviewers to know when this happens in case it has unexpected changes. Giving them a heads up will allow them to check the diff to ensure that there aren't surprises.
If Lando adjusts a patch before landing:
- The "<user> has landed a patch" email for reviewers should include a section explaining that Lando changed the patch with a link to the diff
- The author should receive an extra email explaining that Lando changed their patch with a link to the diff
If Lando did not adjust the patch:
- The "<user> has landed a patch" email should still go to reviewers, just without the extra Lando-specific section
- The author should not be sent an email. (They should not a receive a "<user> has landed a patch" email, because they triggered that action, and there's no new information).
| Reporter | ||
Updated•5 years ago
|
Keywords: conduit-triaged
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•