Remove CharacterEncoding and Symbol types from NamespaceImports.h
Categories
(Core :: JavaScript Engine, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(10 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
"NamespaceImports.h" is intended to be used for common types, but the "CharacterEncoding.h" types are only used in a few places (and most of the time already fully qualified with JS::!), so they don't really fit the label "common types". Let's remove them from "NamespaceImports.h" to keep that header small.
"NamespaceImports.h" also imports JS::Symbol and JS::SymbolCode into the js namespace, but most of the time we're using fully qualified JS::Symbol and JS::SymbolCode. So delete them from "NamespaceImports.h", too.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D92189
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D92190
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D92191
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D92192
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D92193
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D92194
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D92195
|
|
Assignee | |
Comment 9•4 years ago
|
||
Depends on D92196
|
|
Assignee | |
Comment 10•4 years ago
|
||
Forward declarations should be part of TypeDecls.h, but it looks like the
forward declaration of SourceText isn't actually needed anywhere.
Depends on D92197
|
||
Comment 11•4 years ago
|
||
Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7035258b1fdc Part 1: Remove ConstTwoByteChars from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/d70443519891 Part 2: Remove Latin1Chars from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/c04f67d1890d Part 3: Remove Latin1CharsZ from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/e309d39868b6 Part 4: Remove TwoByteChars from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/895233ebd487 Part 5: Remove TwoByteCharsZ from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/d0701021e353 Part 6: Remove UTF8Chars from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/5082cbb8c1e9 Part 7: Remove UTF8CharsZ from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/f7a23e49efd2 Part 8: Remove WTF8Chars from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/51567eff67cd Part 9: Remove Symbol and SymbolCode from namespace js. r=arai https://hg.mozilla.org/integration/autoland/rev/855ede4f82d8 Part 10: Remove SourceText forward declaration. r=arai
|
||
Comment 12•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7035258b1fdc
https://hg.mozilla.org/mozilla-central/rev/d70443519891
https://hg.mozilla.org/mozilla-central/rev/c04f67d1890d
https://hg.mozilla.org/mozilla-central/rev/e309d39868b6
https://hg.mozilla.org/mozilla-central/rev/895233ebd487
https://hg.mozilla.org/mozilla-central/rev/d0701021e353
https://hg.mozilla.org/mozilla-central/rev/5082cbb8c1e9
https://hg.mozilla.org/mozilla-central/rev/f7a23e49efd2
https://hg.mozilla.org/mozilla-central/rev/51567eff67cd
https://hg.mozilla.org/mozilla-central/rev/855ede4f82d8
Description
•