Closed Bug 1668849 Opened 4 years ago Closed 4 years ago

Tabbing through the page range or margin select box leaves a console error

Categories

(Toolkit :: Printing, defect, P3)

defect

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- fixed

People

(Reporter: mstriemer, Assigned: mstriemer)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v86] [old-ui-] )

Attachments

(2 files, 1 obsolete file)

The parent elements for page range and custom margins handle the keypress/paste stuff for their number inputs, but that code is also running when the select is focused.

This is now erroring on keypresses/pastes when the select is focused. This doesn't appear to cause any issues other than in tests though.

Assignee: nobody → mstriemer
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1664570

Whiteboard: [print2020_v84][old-ui-]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mstriemer, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mstriemer)
Whiteboard: [print2020_v84][old-ui-] → [print2020_v85] [old-ui-]

(Whoops, sorry, I missed that this was assigned. But while I'm here, Mark, did you want to just land this, and we can close out the bug in 84? 🙂)

Whiteboard: [print2020_v85] [old-ui-] → [print2020_v84] [old-ui-]

Probably not going to uplift this at this point, so let's push it to 85.

Whiteboard: [print2020_v84] [old-ui-] → [print2020_v85] [old-ui-]

(Moving bugs to 86, part 1.)

Whiteboard: [print2020_v85] [old-ui-] → [print2020_v86][old-ui-]
Attachment #9179291 - Attachment is obsolete: true
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4b420c87706 Part 1: Unify more print settings to PrintSettingNumber r=emalysz https://hg.mozilla.org/integration/autoland/rev/9b78b0018f0c Part 2: Move base components to top of components section r=emalysz
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

This doesn't have any user facing impact, just a code cleanup to avoid a JS exception that didn't cause any problems. Not worth an uplift in my opinion.

Flags: needinfo?(mstriemer)

Moving things to 88, cause we're mostly on Proton these days…

Whiteboard: [print2020_v86][old-ui-] → [print2020_v88] [old-ui-]
Whiteboard: [print2020_v88] [old-ui-] → [print2020_v86] [old-ui-]
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: