1668894 - On mac, system modal has the “All” radio button selected even if a custom page range was set for "Save to pdf" option

Status: RESOLVED DUPLICATE of bug 1663005

(Toolkit :: Printing, defect, P2)

Description

[Emma Malysz]

STR:

1. Open firefox with new print preview ui
2. Choose "Save to pdf" printer
3. Specify page range
4. Open system dialog

ER:
-From radio button is selected with correct range

AR:
-All radio button is selected, page range is incorrect

Comment 1

[Jonathan Watt [:jwatt]]

This appears to be both a bug in the frontend code, and a bug in the platform code.

The nsIPrintSettings object passed to nsPrintDialogServiceX::Show does not have kRangeSpecifiedPageRange set on it (or startPageRange and endPageRange set). That said, if I fix up the settings object the nsPrintDialogServiceX code still doesn't pick up those settings, so we need another bug for the platform work to make that happen.

Comment 2

[Jonathan Watt [:jwatt]]

I must be wrong about there being a frontend bug since this works on Windows. I'll dig a bit later as to why that is.

Comment 3

[Emma Malysz]

There does appear to be a frontend bug with: https://searchfox.org/mozilla-central/rev/7ef5cefd0468b8f509efe38e0212de2398f4c8b3/toolkit/components/printing/content/print.js#219-222

this.settings holds the correct printRange/startRange/endRange, but since it's a save to pdf printer, we're using the default system printer settings.

It appears we had written that to avoid problems with macOS that didn't have printers, but I think we should persist these settings

Comment 4

[Alexandru Trif, Desktop QA [:atrif]]

It seems that I can reproduce the issue with Firefox84.0b4 (20201122152513) and Firefox 85.0a1 (20201122213806) on Windows 10x64 and Windows 7x64 as well by following the STR from comment 0.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

(Moving bugs to 86, part 2.)

Comment 6

[Emma Malysz]

A fix for Bug 1663005 should cover this