1668901 - Add keyboard shortcut to toggle classified failures

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Sarah Clements [:sclements]]

Per a request from Aryx and CosminS, we should add a shortcut for the 'q' key to toggle between a) unclassified failures and b) unclassified and classified failures (include retries and cancels). We should also update the filters menu logic to All jobs, All Failures and Only Unclassified Failures since right now when you deselect "classified" it shows unclassified AND all other jobs.

I took a look at the code and it should be straightforward but I'll wait till my pr for bug 1623951 is merged since some of the logic in the filter model and elsewhere has changed.

Comment 1

[Sarah Clements [:sclements]]

Going to remove myself from this in case someone else wants to pick it up during our upcoming sprint.

Comment 2

[Sarah Clements [:sclements]]

Shortcut should be added here: https://github.com/mozilla/treeherder/blob/master/ui/job-view/KeyboardShortcuts.jsx

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6884

Comment 4

[Sarah Clements [:sclements]]

Comment on attachment 9190150 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6884

Gave this a first pass - requested changes.

Comment 5

[Sarah Clements [:sclements]]

Merged: https://github.com/mozilla/treeherder/commit/820be54206ca999e146b58ad649b0b182282e0f9