166913 - [FIX]Default label applied to <input> buttons with value=""

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Jonas Jørgensen]

Build 2002-09-05-08, Win2k.

Steps to reproduce:
1) Open testcase.

Expected results:
* The submit and reset buttons with no value attributes get a default label.
* The buttons which explicitly sets value to "" gets no label.

Actual results:
* The buttons get the default label even when they have a value="" attribute.

Comment 1

[Jonas Jørgensen]

Attachment: Testcase

Testcase works correctly in: Opera 6.0, MSIE 6.0.
Testcase does not work correctly in: Mozilla 1.1, Mozilla build 2002090508.

Comment 2

[John Keiser (jkeiser)]

The value is what gets put in the button.  If you have a value, we put it in the
button.  If you set the value to blank, therefore, we put blank in the button. 
Unless this is breaking some major topsite, we should do it right rather than
just copying other browsers.

Comment 3

[Jonas Jørgensen]

> If you set the value to blank, therefore, we put blank in the button.

No we don't. If I set value to blank ("") on an <input type="submit">, we put
"Submit Query" in the button. Load the testcase and see for yourself.

Comment 4

[John Keiser (jkeiser)]

Deepest apologies.  I read the summary wrong.  You are right.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Like this?

Comment 6

[Jonas Jørgensen]

> +  if (value.IsEmpty()) {
> +    // Have to have _something_ or we won't be drawn
> +    value.Assign(NS_LITERAL_STRING("  "));

That won't cause "  " two be submitted with the form, will it?

Comment 7

[Boris Zbarsky [:bzbarsky]]

No.

Comment 8

[John Keiser (jkeiser)]

Comment on attachment 98113 [details] [diff] [review]
Like this?

r=jkeiser

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 98113 [details] [diff] [review]
Like this?

sr=jst

Comment 10

[Boris Zbarsky [:bzbarsky]]

taking.

Comment 11

[Boris Zbarsky [:bzbarsky]]

fixed for 1.2b.