Eager evaluation can bail out when used with several remote frames
Categories
(DevTools :: Console, defect)
Tracking
(Not tracked)
People
(Reporter: jdescottes, Unassigned)
References
Details
STRs:
- enable fission
- open https://bug1659969-root.glitch.me/
- open inspector, open split-console
- in markup view, right click on the body element in the first iframe
- click on Use in Console
- (should see
temp0in the console input, eager evaluation should show "body") - in markup view, right click on the body element in the first iframe
- click on Use in Console
ER: eager evaluation should show "body"
AR: eager evaluation shows "ReferenceError: temp0 is not defined"
More discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1668916#c1 and https://phabricator.services.mozilla.com/D92305
Basically the eager evaluation bails at https://searchfox.org/mozilla-central/rev/7ef5cefd0468b8f509efe38e0212de2398f4c8b3/devtools/client/webconsole/actions/input.js#311
Note: When fixing this, we should remove the workaround in browser_jsterm_evaluation_context_selector_inspector.js added by https://phabricator.services.mozilla.com/D92305 (which should also be enough to verify the fix).
| Reporter | ||
Comment 1•6 years ago
|
||
Here is a more technical breakdown:
- right click on node 1 in frame 1 / target 1
- click on use in console
temp0is created in target1- "temp0" is written in the input
- eager eval 1 is performed ("temp0", node1, frame1, target1)
- right click on node 2 in frame 2 / target 2
- eager eval 2 is performed ("temp0", node2, frame2, target2)
- (nothing yet for temp0 in this process -> "ReferenceError: temp0 is not defined")
- click on use in console
temp0is created in target2- "temp0" is written in the input
- eager eval 3 is attempted but bails ("temp0", node2, frame2, target2)
The issue is that from the client's point of view, nothing changed between eager eval 2 and eager eval 3.
The only thing that changed is that something got defined on the server.
Updated•6 years ago
|
Description
•