Closed Bug 1669174 Opened 1 year ago Closed 1 year ago

Stop running framescript (listener.js) code when actors are enabled

Categories

(Testing :: Marionette, task, P1)

Default
task

Tracking

(Fission Milestone:M7, firefox86 fixed)

RESOLVED FIXED
86 Branch
Fission Milestone M7
Tracking Status
firefox86 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Keywords: memory-footprint, Whiteboard: [marionette-fission-mvp])

Attachments

(1 file)

No description provided.
Depends on: 1669176
Depends on: 1664165
No longer depends on: 1669176

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7)

Fission Milestone: --- → M7
Blocks: 1669169
No longer depends on: 1669169
Depends on: 1673823
No longer depends on: 1664165

This can wait until all jobs use actors by default, and we have the framescript fallback job. By doing that we have a complete coverage.

No longer blocks: 1669169
Depends on: 1669169
Blocks: 1669169
No longer depends on: 1669169
Depends on: 1674329
No longer blocks: 1669169
Depends on: 1675248
Depends on: 1676665
Depends on: 1676671
Priority: P3 → P2
Depends on: 1676742
Depends on: 1676709
Depends on: 1669176
Whiteboard: [marionette-fission-mvp] → [marionette-fission-reserve]

All dependencies have been fixed. Now lets get the framescript not loaded when actors are enabled.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1
Depends on: 1682242

As discussed with Marco this bug should remain as MVP.

Whiteboard: [marionette-fission-reserve] → [marionette-fission-mvp]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] (away 12/07 - 12/11) from comment #6)

As discussed with Marco this bug should remain as MVP.

If no resolution by end of day on Dec 20 then bug will be moved back into Reserve Backlog.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d287bfb95caa
[marionette] Don't use Framescript when actors are enabled. r=marionette-reviewers,jgraham
Depends on: 1682757

This needs bug 1682757 to be fixed first.

Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a95e03f79f6
[marionette] Don't use Framescript when actors are enabled. r=marionette-reviewers,jgraham

Backed out for pointerevents failures - see Comment 8

The problem here is with the patch on bug 1682757.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea10c714c606
[marionette] Don't use Framescript when actors are enabled. r=marionette-reviewers,jgraham
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Regressions: 1683216
No longer regressions: 1683841

The memory improvements here are actually:

Improvements:
Ratio Suite Test Platform Options Absolute values (old vs new)
6% Base Content JS macosx1014-64-shippable-qr 2,686,941.33 -> 2,518,160.00
6% Base Content JS linux1804-64-shippable 2,683,950.67 -> 2,515,744.00
6% Base Content JS windows10-64-shippable-qr 2,688,547.33 -> 2,519,948.00
6% Base Content JS windows10-64-shippable 2,688,513.33 -> 2,520,112.00
6% Base Content JS linux1804-64-shippable-qr 2,682,786.00 -> 2,515,292.00
2% Base Content Explicit windows10-64-shippable 8,546,901.33 -> 8,353,792.00

Blocks: 1684690
Depends on: 1664881
No longer blocks: 1684690
No longer depends on: 1664881
You need to log in before you can comment on or make changes to this bug.