1669174 - Stop running framescript (listener.js) code when actors are enabled

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Comment 1

[Chris Peterson [:cpeterson]]

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This can wait until all jobs use actors by default, and we have the framescript fallback job. By doing that we have a complete coverage.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All dependencies have been fixed. Now lets get the framescript not loaded when actors are enabled.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We will see a lot of memory usage improvements with that fix landed!

https://treeherder.mozilla.org/perfherder/compare?originalProject=mozilla-central&newProject=try&newRevision=f54b0d43b5ba8ea9de405077e99a0bf9e3e1203d&framework=4&selectedTimeRange=172800

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1669174 - [marionette] Don't use Framescript when actors are enabled.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As discussed with Marco this bug should remain as MVP.

Comment 7

[Marco Mucci [:MarcoM]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] (away 12/07 - 12/11) from comment #6)

As discussed with Marco this bug should remain as MVP.

If no resolution by end of day on Dec 20 then bug will be moved back into Reserve Backlog.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d287bfb95caa
[marionette] Don't use Framescript when actors are enabled. r=marionette-reviewers,jgraham

Comment 9

[Dorel Luca [:dluca]]

Backed out 1 changesets (bug 1669174) for WPT failures in uievents/click/auxclick_event.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=324591693&repo=autoland&lineNumber=14740

Push with failues:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=d287bfb95caa1567d71868017661ddcb55ad0e3e

Backout:
https://hg.mozilla.org/integration/autoland/rev/914398229db8d83caf1e3501c3d760f800c8d1e9

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This needs bug 1682757 to be fixed first.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a95e03f79f6
[marionette] Don't use Framescript when actors are enabled. r=marionette-reviewers,jgraham

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out for pointerevents failures - see Comment 8

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The problem here is with the patch on bug 1682757.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea10c714c606
[marionette] Don't use Framescript when actors are enabled. r=marionette-reviewers,jgraham

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ea10c714c606

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The memory improvements here are actually:

Improvements:
Ratio Suite Test Platform Options Absolute values (old vs new)
6% Base Content JS macosx1014-64-shippable-qr 2,686,941.33 -> 2,518,160.00
6% Base Content JS linux1804-64-shippable 2,683,950.67 -> 2,515,744.00
6% Base Content JS windows10-64-shippable-qr 2,688,547.33 -> 2,519,948.00
6% Base Content JS windows10-64-shippable 2,688,513.33 -> 2,520,112.00
6% Base Content JS linux1804-64-shippable-qr 2,682,786.00 -> 2,515,292.00
2% Base Content Explicit windows10-64-shippable 8,546,901.33 -> 8,353,792.00