1669207 - New UI has saved invalid margins to prefs, causing print preview to become completely disabled and unusable

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P1)

Description

[Julien Wajsberg [:julienw]]

Attachment: Capture d’écran de 2020-10-05 11-20-11.png

STR:

1. Set some margin values to a negative value (eg: set to -1)
2. Try to print preview.

=> The print preview is all disabled, without any clear information about how to resolve the issue.

Only when opening the "more settings" dropdown that the user can see the margin is invalid, and can resolve it.

Comment 1

[Julien Wajsberg [:julienw]]

BTW I also that believe the "Printer" select shouldn't be disabled. Indeed the bogus values are per-printer and so we should be able to change the printer. Especially in this case I was interested in the feature "save as PDF" but couldn't even select it.

Comment 2

[Jonathan Watt [:jwatt]]

(In reply to Julien Wajsberg [:julienw] from comment #0)

1. Set some margin values to a negative value (eg: set to -1)

Did you do this by setting them in about:config, or some other way?

(In reply to Julien Wajsberg [:julienw] from comment #1)

BTW I also that believe the "Printer" select shouldn't be disabled.

Can you report that as a separate bug?

Comment 3

[Julien Wajsberg [:julienw]]

(In reply to Jonathan Watt [:jwatt] from comment #2)

(In reply to Julien Wajsberg [:julienw] from comment #0)

1. Set some margin values to a negative value (eg: set to -1)

Did you do this by setting them in about:config, or some other way?

No I get these weird values without setting them manually. I mozregressed and found that the last patch in bug 1663503 got me these values (I commented there too).

(In reply to Julien Wajsberg [:julienw] from comment #1)

BTW I also that believe the "Printer" select shouldn't be disabled.

Can you report that as a separate bug?

Sure, I filed bug 1669225.

Comment 4

[Jonathan Watt [:jwatt]]

Ah, thanks. And thanks for filing that other bug.

Comment 5

[Emma Malysz]

Attachment: Bug 1669207, ensure margins are initialized with valid settings

If margins are manually set to negative entries or if the selected printer
had bad values, we need to correctly reset the pref value to valid default
margins.

Comment 6

[Jonathan Watt [:jwatt]]

FWIW in bug 1669370 I've landed a patch to reject obviously bad setting in platform code when reading them from prefs (i.e. under initPrintSettingsFromPrefs()).

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1663503

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91b417dc72dc
ensure margins are initialized with valid settings r=sfoster

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/91b417dc72dc

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

I am unable to save invalid margins using the french 83.0b2 build across-platforms. Confirming the fix.