Closed Bug 1669213 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25979 - Get the gitignore cache working, consistently use fast JSON modules

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25979 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25979
Details from upstream follow.

b'Sam Sneddon <gsnedders@apple.com>' wrote:

Get the gitignore cache working, consistently use fast JSON modules

Some Sam Sneddon person broke the gitignore cache with e98eee5aec6 (as MutableMapping provides a default __bool__, effectively returning bool(len(self))), and this gets it working again.

This also slightly more consistently gets us using quicker JSON modules, and factors out a bunch of code for this which uses whichever we want. This provides a further benefit for those with them installed (ujson especially).

A few benchmarks (Py3.8, with a modified untracked file in the tree):

(I don't remember why we set caller_owns_obj=False in manifest.write, given it exists for that reason, but with that set to True and with all the above we're down to 1.52s.)

Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae756f0230ee
[wpt PR 25979] - Get the gitignore cache working, consistently use fast JSON modules, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ae756f0230ee

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.