166922 - Can't Delete Rows of selected cells

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Rafael Ebron (:rebron)]

Feature regression.  Works okay with Netscape 7.0, Mozilla 1.0.  
To replicate, create page with a table that has many rows and columns say 6x6.
Select two or three rows by highlighting. 
Attempt to delete the rows.

Notice that the rows don't get deleted.  You need to delete rows one row at a time.
Using: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020904

Comment 1

[sujay]

--> cmanske

Comment 2

[Charles Manske]

This was busted during nsIEditorShell to nsITableEditor conversion in editor.js

Comment 3

[Charles Manske]

Attachment: patch v1

The root of this bug is this line in editor.js:
cell = gEditor.getNextSelectedCell();
This happened during conversion from nsIEditorShell methods to nsITableEditor.
The methods in nsIEditorShell had expected code patterns: e.g., a method 
getNextSelectedCell() *should* be expected to return the next cell! But the
nsITableEditor methods required JS "out" param objects the way they were
written.
So I did a review of all the nsITableEditor methods and decided to clean them
all up:
I changed getSelectedOrParentTableElement, getFirstSelectedCell, 
getFirstSelectedCellInTable, and getNextSelectedCell to return the element 
instead of requiring "out" params. This necessitated a change in the order
of params in nsITableEditor.idl related files since the primary return
param must be the last one in the C++ methods. All other changes were the 
result of these changes in the order params. Luckily, that kind of change is
easy to make since it won't compile or link if all uses of these methods aren't

fixed! There's also some cleanup in the comments in nsITableEditor.idl.

Comment 4

[Charles Manske]

I changed all of these comment strings:
"in C++ returns:" to "Returns (in C++)"
per reviewer comments

Comment 5

[Akkana Peck]

Comment on attachment 98489 [details] [diff] [review]
patch v1

r=akkana

Comment 6

[Joe Hewitt (gone)]

Comment on attachment 98489 [details] [diff] [review]
patch v1

sr=hewitt

Comment 7

[Charles Manske]

checked into 1.2beta trunk

Comment 8

[sujay]

verified in 9/17 trunk...

Rafael, this should be fixed for you now...let us know if you find otherwise.

Comment 9

[Rafael Ebron (:rebron)]

Works beautifully.  Thanks for the quick turnaround I do use this feature quite
a bit.